5 days ago I created my first PR: "new planar_vertex_six_coloring() algorithm with examples, tests and doc" https://github.com/boostorg/graph/pull/387 CI helped me to fix things I was responsible for. But after that CI still fails in code I am not responsible for. From release notes: https://www.boost.org/users/history/version_1_86_0.html "...Graph: Major update: C++14 is the new minimum standard; this was partly dictated by dependencies (at least to C++11) and partly by choice. If you require support for an older standard, please contact the maintainer. ..." Somebody (who?) forgot to tell CI that minimum requirement. Example error caused by this: gcc.compile.c++ ../../../bin.v2/libs/graph/test/gursoy_atun_layout_test.test/gcc-5/debug/x86_64/cxxstd-11-iso/threading-multi/visibility-hidden/gursoy_atun_layout_test.o In file included from ../../../boost/math/constants/constants.hpp:11:0, from ../../../boost/graph/topology.hpp:16, from ../../../boost/graph/gursoy_atun_layout.hpp:34, from gursoy_atun_layout_test.cpp:10: ../../../boost/math/tools/config.hpp:28:6: warning: #warning "Boost.Math requires C++14" [-Wcpp] # warning "Boost.Math requires C++14" ^ In file included from ../../../boost/math/tools/mp.hpp:15:0, from ../../../boost/math/policies/policy.hpp:11, from ../../../boost/math/constants/constants.hpp:16, from ../../../boost/graph/topology.hpp:16, from ../../../boost/graph/gursoy_atun_layout.hpp:34, from gursoy_atun_layout_test.cpp:10: ../../../boost/math/tools/type_traits.hpp:208:12: error: 'std::is_final' has not been declared using std::is_final; Since this is my first PR, will there be someone helping me in PR 387? Who owns CI? Can issues be created against CI? Or do I understand this completely wrong? Regards, Hermann.
On 2024-10-07 21:26, hermann@stamm-wilbrandt.de wrote:
Since this is my first PR, will there be someone helping me in PR 387?
After having posted to the list, I got help from grisumbras from C++ alliance in PR 387.
Who owns CI?
C++ alliance according comment in "graph/.drone.star".
Can issues be created against CI?
Not needed, I was asked to remove all C++11 lines like this https://github.com/boostorg/graph/blob/develop/.drone.star#L17 After I did that https://github.com/boostorg/graph/pull/387 got successful check.
Somebody (who?) forgot to tell CI that minimum requirement.
Yes. Regards, Hermann.
Somebody (at present) is me, and sometimes it takes me a while to get around to noticing and doing things. Thanks for the interesting PR, I'll continue the discussion over there on GitHub. Cheers. Jeremy On Tue, 8 Oct 2024 at 09:08, Hermann Stamm-Wilbrandt via Boost < boost@lists.boost.org> wrote:
On 2024-10-07 21:26, hermann@stamm-wilbrandt.de wrote:
Since this is my first PR, will there be someone helping me in PR 387?
After having posted to the list, I got help from grisumbras from C++ alliance in PR 387.
Who owns CI?
C++ alliance according comment in "graph/.drone.star".
Can issues be created against CI?
Not needed, I was asked to remove all C++11 lines like this https://github.com/boostorg/graph/blob/develop/.drone.star#L17
After I did that https://github.com/boostorg/graph/pull/387 got successful check.
Somebody (who?) forgot to tell CI that minimum requirement.
Yes.
Regards,
Hermann.
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
participants (2)
-
hermann@stamm-wilbrandt.de
-
Jeremy Murphy