Master Branch is now open for bug fixes
The master branch is now open for bug fixes and documentation changes. Other changes by release manager permission, as described in https://github.com/boostorg/wiki/wiki/Releases%3A-Beta-Merge-Policy The next deadline: On August 5th, master closes for all changes. As always, the calendar is at https://www.boost.org/development/ — Marshall
May I merge these commits to JSON's master? Documentation: https://github.com/boostorg/json/commit/e084a2918cc121528bcf58e04d026f5cbb89... 1.83.0 release notes https://github.com/boostorg/json/commit/b8ccd1499e31f77e6476bb529b0d8d6f5f82... move number_precision to Constants in reference https://github.com/boostorg/json/commit/ca04e885dc3e0df12130de40efd468f9918b... rebalance columns in reference docs https://github.com/boostorg/json/commit/0273148f693470d916d948f3e69571ce9aa6... replaced references to cppalliance/json with references to boostorg/json where appropriate Bug fix: https://github.com/boostorg/json/commit/ed9e2f536aede6c0fefd759f61412cd37de1... require ARM64 for __umulh чт, 13 июл. 2023 г. в 16:43, Marshall Clow via Boost <boost@lists.boost.org>:
The master branch is now open for bug fixes and documentation changes.
On Jul 26, 2023, at 5:58 AM, Дмитрий Архипов via Boost <boost@lists.boost.org> wrote:
May I merge these commits to JSON's master?
Documentation: https://github.com/boostorg/json/commit/e084a2918cc121528bcf58e04d026f5cbb89... 1.83.0 release notes https://github.com/boostorg/json/commit/b8ccd1499e31f77e6476bb529b0d8d6f5f82... move number_precision to Constants in reference https://github.com/boostorg/json/commit/ca04e885dc3e0df12130de40efd468f9918b... rebalance columns in reference docs https://github.com/boostorg/json/commit/0273148f693470d916d948f3e69571ce9aa6... replaced references to cppalliance/json with references to boostorg/json where appropriate
You do not require permission for doc or test fixes.
Bug fix: https://github.com/boostorg/json/commit/ed9e2f536aede6c0fefd759f61412cd37de1... require ARM64 for __umulh
Go ahead. — Marshall
Hi, The following commits: https://github.com/boostorg/mpi/compare/master...develop - fixes documentation typos. - add missing declaration in header files. - add test code for ctest. - reports in Boost.MPI somes changes made in Boost.serialization - fixes some bugs. The only new feature is that it is now possible to get the MPI version string I would not qualify any of those changes as critical, but some people have been waiting more than a year for them because of me. Can I merge them ? Thanks ---- Alain Miniussi DSI, Pôles Calcul et Genie Log. Observatoire de la Côte d'Azur Tél. : +33609650665 ----- On Jul 13, 2023, at 3:43 PM, Marshall Clow via Boost boost@lists.boost.org wrote:
The master branch is now open for bug fixes and documentation changes. Other changes by release manager permission, as described in https://github.com/boostorg/wiki/wiki/Releases%3A-Beta-Merge-Policy
The next deadline: On August 5th, master closes for all changes.
As always, the calendar is at https://www.boost.org/development/
— Marshall
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
On Aug 1, 2023, at 6:27 AM, Alain O' Miniussi <alain.miniussi@oca.eu> wrote:
Hi,
The following commits: https://github.com/boostorg/mpi/compare/master...develop
- fixes documentation typos. - add missing declaration in header files. - add test code for ctest. - reports in Boost.MPI somes changes made in Boost.serialization - fixes some bugs.
The only new feature is that it is now possible to get the MPI version string
I would not qualify any of those changes as critical, but some people have been waiting more than a year for them because of me.
Can I merge them ?
Some of these changes look pretty substantial - https://github.com/boostorg/mpi/commit/da602162b4b00e8e3134a991d0c836f10cfe0... for example, changes 54 files. Are these the kind of changes we should be making on the day before a release? On the other hand, if I just do "git diff master..develop --name-status” I see far fewer changes. So I guess I’m confused. — Marshall
Hi, Right, somehow I overlooked that one. That specific commit has been made by Robert Ramey, I guess to comply with changes made in Serialization. But it seems that, in serialization, those changes are still in develop. On the over hand, merged Boost.MPI did pass the test on my platform with the master branch of serialization... Maybe we should at least wait for Robert input and probably skip this one. Alain ----- On Aug 1, 2023, at 6:49 PM, Marshall Clow <mclow.lists@gmail.com> wrote:
On Aug 1, 2023, at 6:27 AM, Alain O' Miniussi <alain.miniussi@oca.eu> wrote:
Hi,
The following commits: https://github.com/boostorg/mpi/compare/master...develop
- fixes documentation typos. - add missing declaration in header files. - add test code for ctest. - reports in Boost.MPI somes changes made in Boost.serialization - fixes some bugs.
The only new feature is that it is now possible to get the MPI version string
I would not qualify any of those changes as critical, but some people have been waiting more than a year for them because of me.
Can I merge them ?
Some of these changes look pretty substantial - [ https://github.com/boostorg/mpi/commit/da602162b4b00e8e3134a991d0c836f10cfe0... | https://github.com/boostorg/mpi/commit/da602162b4b00e8e3134a991d0c836f10cfe0... ] for example, changes 54 files.
Are these the kind of changes we should be making on the day before a release? On the other hand, if I just do "git diff master..develop --name-status” I see far fewer changes.
So I guess I’m confused.
— Marshall
On Aug 1, 2023, at 10:48 AM, Alain O' Miniussi <alain.miniussi@oca.eu> wrote:
----- On Aug 1, 2023, at 6:49 PM, Marshall Clow <mclow.lists@gmail.com> wrote:
On Aug 1, 2023, at 6:27 AM, Alain O' Miniussi <alain.miniussi@oca.eu> wrote: Hi,
The following commits: https://github.com/boostorg/mpi/compare/master...develop
- fixes documentation typos. - add missing declaration in header files. - add test code for ctest. - reports in Boost.MPI somes changes made in Boost.serialization - fixes some bugs.
The only new feature is that it is now possible to get the MPI version string
I would not qualify any of those changes as critical, but some people have been waiting more than a year for them because of me.
Can I merge them ? Some of these changes look pretty substantial - https://github.com/boostorg/mpi/commit/da602162b4b00e8e3134a991d0c836f10cfe0... for example, changes 54 files.
Are these the kind of changes we should be making on the day before a release? On the other hand, if I just do "git diff master..develop --name-status” I see far fewer changes.
So I guess I’m confused.
Hi,
Right, somehow I overlooked that one. That specific commit has been made by Robert Ramey, I guess to comply with changes made in Serialization. But it seems that, in serialization, those changes are still in develop. On the over hand, merged Boost.MPI did pass the test on my platform with the master branch of serialization... Maybe we should at least wait for Robert input and probably skip this one.
I’ve compared the master and develop branches manually. If you think that these changes won’t cause any problems, then you can go ahead. — Marshall
Am 01.08.23 um 18:49 schrieb Marshall Clow via Boost:
Some of these changes look pretty substantial - https://github.com/boostorg/mpi/commit/da602162b4b00e8e3134a991d0c836f10cfe0... for example, changes 54 files. Are these the kind of changes we should be making on the day before a release?
On the other hand, if I just do "git diff master..develop --name-status” I see far fewer changes.
So I guess I’m confused.
What matters is only https://github.com/boostorg/mpi/compare/master...develop which has 42 files changed (likely what your command outputs). Especially https://github.com/boostorg/mpi/compare/master...develop#diff-efe111aae207f5... is worth adding: Fixing an actual and potentially serious bug due to missing the element size in the size calculation. That commit you were referring to is titled: "Merge branch 'develop' of https://github.com/boostorg/mpi into develop", so this isn't an actual change but simply updating a local branch with the remote changes which somehow made it to the final commits but is essentially a no-op as those changes were done elsewhere. So basically the local develop branch wasn't rebased onto the remote branch but the remote merged, likely due to some force-pushing or so. There are some more like that :-/ Alex
participants (4)
-
Alain O' Miniussi -
Alexander Grund -
Marshall Clow -
Дмитрий Архипов