[test][gcc-4.3.0][trunk] missing include in boost/test/impl/debug.ipp
The trunk version of boost/test/impl/debug.ipp uses std::memcpy without having included an appropriate header, as shown in http://tinyurl.com/yt3hv8 : [...] In file included from ../boost/test/included/unit_test.hpp:19, from ../libs/test/test/online_test.cpp:17: ../boost/test/impl/debug.ipp: In function ???char* boost::debug::<unnamed> ::copy_arg(boost::debug::<unnamed>::mbuffer&, boost::unit_test::const_string)???: ../boost/test/impl/debug.ipp:338: error: ???memcpy??? is not a member of ???std??? [...] Curiously enough it is only GCC 4.3.0 that catches the problem, probably because std::memcpy is implicitly included by some header or another in all other platforms. The attached patch should solve the problem. OK to commit? Thank you, Joaquín M López Muñoz Telefónica, Investigación y Desarrollo
Gennadiy Rozental ha escrito:
JOAQUIN LOPEZ MU?Z <joaquin <at> tid.es> writes:
The attached patch should solve the problem. OK to commit?
Go ahead.
Done. Regards, Joaquín M López Muñoz Telefónica, Investigación y Desarrollo
On Tue, Nov 13, 2007 at 11:17:58PM +0100, "JOAQUIN LOPEZ MU?Z" wrote:
The trunk version of boost/test/impl/debug.ipp uses std::memcpy without having included an appropriate header, as shown in http://tinyurl.com/yt3hv8 :
This is bug #1438. Please note that I filed already bug #1432 with a patch which fixes this and even more errors (and warnings) so the rest should be applied as well (doesn't need much time, but I probably removed wrongly a few variable definitions in unnamed namespaces which should be addressed in a better way (e.g. moving it into a .cpp file or a header file which each project needs to include exactly once). Jens
Jens Seidel ha escrito:
On Tue, Nov 13, 2007 at 11:17:58PM +0100, "JOAQUIN LOPEZ MU?Z" wrote:
The trunk version of boost/test/impl/debug.ipp uses std::memcpy without having included an appropriate header, as shown in http://tinyurl.com/yt3hv8 :
This is bug #1438. Please note that I filed already bug #1432 with a patch which fixes this and even more errors (and warnings) so the rest should be applied as well (doesn't need much time, but I probably removed wrongly a few variable definitions in unnamed namespaces which should be addressed in a better way (e.g. moving it into a .cpp file or a header file which each project needs to include exactly once).
Oh, I didn't notice the existence of tickets 1432 and 1438, sorry. I just closed 1438. As for 1432 you should ask for patching permission by the lib author (Gennadiy). Once you've got it, if you need someone to commit the patches drop me a note. Joaquín M López Muñoz Telefónica, Investigación y Desarrollo
Jens Seidel <jensseidel <at> users.sf.net> writes:
On Tue, Nov 13, 2007 at 11:17:58PM +0100, "JOAQUIN LOPEZ MU?Z" wrote:
The trunk version of boost/test/impl/debug.ipp uses std::memcpy without having included an appropriate header, as shown in http://tinyurl.com/yt3hv8 :
This is bug #1438. Please note that I filed already bug #1432 with a patch which fixes this and even more errors (and warnings) so the rest should be applied as well (doesn't need much time, but I probably removed wrongly a few variable definitions in unnamed namespaces which should be addressed in a better way (e.g. moving it into a .cpp file or a header file which each project needs to include exactly once).
I've seen your patch. I touches a lot of places in same cases wrong, in some unclear. I don'y have time now to deal with it. Only critical fixes are going to be applied.
On Wed, Nov 14, 2007 at 05:22:47PM +0000, Gennadiy Rozental wrote:
Jens Seidel <jensseidel <at> users.sf.net> writes:
On Tue, Nov 13, 2007 at 11:17:58PM +0100, "JOAQUIN LOPEZ MU?Z" wrote:
The trunk version of boost/test/impl/debug.ipp uses std::memcpy without having included an appropriate header, as shown in http://tinyurl.com/yt3hv8 :
This is bug #1438. Please note that I filed already bug #1432 with a patch which fixes this and even more errors (and warnings) so the rest should be applied as well (doesn't need much time, but I probably removed wrongly a few variable definitions in unnamed namespaces which should be addressed in a better way (e.g. moving it into a .cpp file or a header file which each project needs to include exactly once).
I've seen your patch. I touches a lot of places in same cases wrong, in some unclear. I don'y have time now to deal with it. Only critical fixes are going to be applied.
You're right Gennadiy! My patch contained also such stuff and also a few remarks where I fixed comments and which I did not in patches for other libraries. I did this because I know that Boost.Test is very good maintained (indeed, at least this is my opinion) and I know nearly for sure that you will look also on the non critical stuff. OK, I attached a new patch which fixes really important stuff. As usual I added also a short comment (inside the code) to show the reason for the patch. These comments should be removed after beeing checked. Thanks, Jens
participants (4)
-
"JOAQUIN LOPEZ MU?Z" -
Gennadiy Rozental -
Jens Seidel -
Joaquín Mª López Muñoz