Re: [boost] [Boost-commit] svn:boost r66441 - in trunk/tools/build/v2: . engine/src engine/src/modules tools
Hi ! On Sunday, 7. November 2010 20:51:11 admin@thefireflyproject.us wrote:
Modified: trunk/tools/build/v2/engine/src/modules/order.c =========================================================================== === --- trunk/tools/build/v2/engine/src/modules/order.c (original) +++ trunk/tools/build/v2/engine/src/modules/order.c 2010-11-07 14:51:05 EST (Sun, 07 Nov 2010) @@ -50,8 +50,8 @@
if (colors[adjacent_vertex] == white) do_ts(graph, adjacent_vertex, colors, result_ptr); - else if (colors[adjacent_vertex] == gray) - ; /* This is loop. Not sure what to do... */ + //else if (colors[adjacent_vertex] == gray) + //; /* This is loop. Not sure what to do... */ } colors[current_vertex] = black; **result_ptr = current_vertex;
Are you sure that you really wanted to commit this ? Yours, Jürgen -- * Dipl.-Math. Jürgen Hunold ! Ingenieurgesellschaft für * voice: ++49 511 262926 57 ! Verkehrs- und Eisenbahnwesen mbH * fax : ++49 511 262926 99 ! Lister Straße 15 * juergen.hunold@ivembh.de ! www.ivembh.de * * Geschäftsführer: ! Sitz des Unternehmens: Hannover * Prof. Dr.-Ing. Thomas Siefer ! Amtsgericht Hannover, HRB 56965 * PD Dr.-Ing. Alfons Radtke !
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Sun, 7 Nov 2010 21:27:50 +0100 Jürgen Hunold <juergen.hunold@ivembh.de> wrote:
Hi !
On Sunday, 7. November 2010 20:51:11 admin@thefireflyproject.us wrote:
Modified: trunk/tools/build/v2/engine/src/modules/order.c =========================================================================== === --- trunk/tools/build/v2/engine/src/modules/order.c (original) +++ trunk/tools/build/v2/engine/src/modules/order.c 2010-11-07 14:51:05 EST (Sun, 07 Nov 2010) @@ -50,8 +50,8 @@
if (colors[adjacent_vertex] == white) do_ts(graph, adjacent_vertex, colors, result_ptr); - else if (colors[adjacent_vertex] == gray) - ; /* This is loop. Not sure what to do... */ + //else if (colors[adjacent_vertex] == gray) + //; /* This is loop. Not sure what to do... */ } colors[current_vertex] = black; **result_ptr = current_vertex;
Are you sure that you really wanted to commit this ?
Yours,
Jürgen
It's dead code. I'm sure it doesn't matter if I remove it or not. - -- Bryce Lelbach aka wash http://groups.google.com/group/ariel_devel -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkzXD5gACgkQO/fqqIuE2t4UrwCdHBUXHdbUkSvfKvTJfTd5aUI3 /rcAoODScBlj8VlaAZEuFxVNG3drLUEZ =27FZ -----END PGP SIGNATURE-----
Bryce Lelbach wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On Sun, 7 Nov 2010 21:27:50 +0100 Jürgen Hunold <juergen.hunold@ivembh.de> wrote:
Hi !
On Sunday, 7. November 2010 20:51:11 admin@thefireflyproject.us wrote:
Modified: trunk/tools/build/v2/engine/src/modules/order.c =========================================================================== === --- trunk/tools/build/v2/engine/src/modules/order.c (original) +++ trunk/tools/build/v2/engine/src/modules/order.c 2010-11-07 14:51:05 EST (Sun, 07 Nov 2010) @@ -50,8 +50,8 @@
if (colors[adjacent_vertex] == white) do_ts(graph, adjacent_vertex, colors, result_ptr); - else if (colors[adjacent_vertex] == gray) - ; /* This is loop. Not sure what to do... */ + //else if (colors[adjacent_vertex] == gray) + //; /* This is loop. Not sure what to do... */ } colors[current_vertex] = black; **result_ptr = current_vertex;
Are you sure that you really wanted to commit this ?
Yours,
Jürgen
It's dead code. I'm sure it doesn't matter if I remove it or not.
It is not dead code, it's code that has no side effects. Are you sure clang actually claims is "dead", that is, never executed? If so, it's clang bug. Also, "//" comments are not OK in C code, which bjam is at present. And generally, I'd prefer not to have executable code commented out, as it sends mixed signals to readers. If clang really cannot be persuaded, you can put this: /* The vertex is either black, in which case we don't have to do anything, a gray, in which case we have a loop. If we have a loop, it's not clear that useful diagnostic we can emit. */ Thanks, Volodya
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Sun, 7 Nov 2010 21:27:50 +0100 Jürgen Hunold <juergen.hunold@ivembh.de> wrote:
Hi !
On Sunday, 7. November 2010 20:51:11 admin@thefireflyproject.us wrote:
Modified: trunk/tools/build/v2/engine/src/modules/order.c =========================================================================== === --- trunk/tools/build/v2/engine/src/modules/order.c (original) +++ trunk/tools/build/v2/engine/src/modules/order.c 2010-11-07 14:51:05 EST (Sun, 07 Nov 2010) @@ -50,8 +50,8 @@
if (colors[adjacent_vertex] == white) do_ts(graph, adjacent_vertex, colors, result_ptr); - else if (colors[adjacent_vertex] == gray) - ; /* This is loop. Not sure what to do... */ + //else if (colors[adjacent_vertex] == gray) + //; /* This is loop. Not sure what to do... */ } colors[current_vertex] = black; **result_ptr = current_vertex;
Are you sure that you really wanted to commit this ?
Yours,
Jürgen
It's dead code. All it does is generate a warning with clang. The warning it generates comes from the pass that eliminates dead code. There's a comment there indicating that the original author was unsure what to do at that point. I left the comment and the original condition for the sake of documentation. - -- Bryce Lelbach aka wash http://groups.google.com/group/ariel_devel -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkzXEIsACgkQO/fqqIuE2t7AwQCfSWBso/iIOkz/RKoztV/wormn 5/UAnRchSZF7e1YSc03YrGgb5MK2M97X =CH4O -----END PGP SIGNATURE-----
participants (3)
-
Bryce Lelbach -
Jürgen Hunold -
Vladimir Prus