[Review:Contract] Boost.Contract Library is Accepted
Lorenzo Caminiti's Boost.Contract Library is hereby accepted into Boost. I will be brief but that should in no way be construed as a lack of enthusiasm. Reviewing the review commentary was a genuine pleasure. Anyone interested in this domain could learn a lot by going through the threads the way I did. There were five "yes" votes, one of which was very late (but I'm counting it), and one of which was conditional, and one "no" vote. I am accepting the library unconditionally because of Lorenzo's demonstrated responsiveness to issues. He gave thoughtful responses to the review comments and entered every issue raised that remained open into a bug database (http://sourceforge.net/apps/trac/contractpp/report/3). Congratulations, Lorenzo! -- Dave Abrahams BoostPro Computing Software Development Training http://www.boostpro.com Clang/LLVM/EDG Compilers C++ Boost
On Sun, Sep 16, 2012 at 7:16 PM, Dave Abrahams <dave@boostpro.com> wrote:
Lorenzo Caminiti's Boost.Contract Library is hereby accepted into Boost.
I will be brief but that should in no way be construed as a lack of enthusiasm. Reviewing the review commentary was a genuine pleasure. Anyone interested in this domain could learn a lot by going through the threads the way I did.
There were five "yes" votes, one of which was very late (but I'm counting it), and one of which was conditional
I essentially accepted to make all changes requested by Vicente's conditional YES.
, and one "no" vote. I am accepting the library unconditionally because of Lorenzo's demonstrated responsiveness to issues. He gave thoughtful responses to the review comments and entered every issue raised that remained open into a bug database (http://sourceforge.net/apps/trac/contractpp/report/3).
Congratulations, Lorenzo!
Thanks :D Thank you very much Dave for being the review manager! Thanks a lot to everyone that submitted a review and participated in the discussions!! --Lorenzo
Le 17/09/12 05:31, Lorenzo Caminiti a écrit :
On Sun, Sep 16, 2012 at 7:16 PM, Dave Abrahams <dave@boostpro.com> wrote:
Lorenzo Caminiti's Boost.Contract Library is hereby accepted into Boost.
I essentially accepted to make all changes requested by Vicente's conditional YES.
Congratulations Lorenzo, Vicente
On Mon, Sep 17, 2012 at 8:31 AM, Thorsten Ottosen <thorsten.ottosen@dezide.com> wrote:
On 17-09-2012 04:16, Dave Abrahams wrote:
Lorenzo Caminiti's Boost.Contract Library is hereby accepted into Boost.
Congratulations, Lorenzo!
+1. Nice work! Sorry for not giving a review, but I felt my position would not yield an impartial review.
Thanks :) Well, if you have the time to read the docs, I'm always happy to hear your comments even if not in the form of a review (but the lib follows your N-papers rather closely). Plus, if we were to re-submit N1962 for C++1x, it would make sense to cite the lib and /consider/ a couple of small additions from the lib (e.g., static/volatile class invariants, assertions requirements, class invariant broken handlers specialized on entry/exit/throw). After all, I wrote the lib but you wrote the C++ Contract Programming requirements! Thanks! --Lorenzo
participants (4)
-
Dave Abrahams -
Lorenzo Caminiti -
Thorsten Ottosen -
Vicente J. Botet Escriba