iterator/transform_iterator.hpp has more dependencies than it needs?
My work likes to keep a minimal subset of boost in the project tree. One of the libraries we are using (I can't remember which off hand) requires transform_iterator.hpp which includes boost/function.hpp. I noticed when merging in the latest RC updates that I had commented out this header as it doesn't appear to be necessary and saves me from bringing yet another library into the mini-boost folder. Is this dependency actually necessary? Thanks, Michael Marcin
"Michael Marcin" <mmarcin@method-solutions.com> writes:
My work likes to keep a minimal subset of boost in the project tree. One of the libraries we are using (I can't remember which off hand) requires transform_iterator.hpp which includes boost/function.hpp. I noticed when merging in the latest RC updates that I had commented out this header as it doesn't appear to be necessary and saves me from bringing yet another library into the mini-boost folder.
Is this dependency actually necessary?
Doesn't seem like it should be. Why not take out the #include and see what breaks? -- Dave Abrahams Boost Consulting www.boost-consulting.com
David Abrahams wrote:
"Michael Marcin" <mmarcin@method-solutions.com> writes:
My work likes to keep a minimal subset of boost in the project tree. One of the libraries we are using (I can't remember which off hand) requires transform_iterator.hpp which includes boost/function.hpp. I noticed when merging in the latest RC updates that I had commented out this header as it doesn't appear to be necessary and saves me from bringing yet another library into the mini-boost folder.
Is this dependency actually necessary?
Doesn't seem like it should be. Why not take out the #include and see what breaks?
I have and nothing seems to break locally but I don't run full regressions so I'm not sure nothing breaks. - Michael Marcin
Michael Marcin wrote:
David Abrahams wrote:
"Michael Marcin" <mmarcin@method-solutions.com> writes:
My work likes to keep a minimal subset of boost in the project tree. One of the libraries we are using (I can't remember which off hand) requires transform_iterator.hpp which includes boost/function.hpp. I noticed when merging in the latest RC updates that I had commented out this header as it doesn't appear to be necessary and saves me from bringing yet another library into the mini-boost folder.
Is this dependency actually necessary?
Doesn't seem like it should be. Why not take out the #include and see what breaks?
I have and nothing seems to break locally but I don't run full regressions so I'm not sure nothing breaks.
Any chance of trying the simple patch for HEAD of deleting line 10 from boost/iterator/transform_iterator.hpp that reads:"#include <boost/function.hpp>" in the interest of reduced coupling? Thanks, Michael Marcin
participants (2)
-
David Abrahams -
Michael Marcin