[exception] missing workarounds for msvc 4265 warning

Hi ! My coworkers found some more annoying msv 4265 warnings. (missing virtual destructor. The attached patch adds the necessary workaround (analog to gcc). Okay to commit ? Yours, Jürgen -- * Dipl.-Math. Jürgen Hunold ! Ingenieurgesellschaft für * voice: ++49 511 262926 57 ! Verkehrs- und Eisenbahnwesen mbH * fax : ++49 511 262926 99 ! Lister Straße 15 * juergen.hunold@ivembh.de ! www.ivembh.de * * Geschäftsführer: ! Sitz des Unternehmens: Hannover * Prof. Dr.-Ing. Thomas Siefer ! Amtsgericht Hannover, HRB 56965 * PD Dr.-Ing. Alfons Radtke !

Jürgen Hunold wrote:
Hi !
My coworkers found some more annoying msv 4265 warnings. (missing virtual destructor. The attached patch adds the necessary workaround (analog to gcc).
Since MSVC provides a way to disable warnings in code wouldn't it be better to pragma push, warning disable, and pop then to actually change the code? Thanks, Michael Marcin

Hi Michael ! On Tuesday 19 August 2008 18:36:39 Michael Marcin wrote:
Since MSVC provides a way to disable warnings in code wouldn't it be better to pragma push, warning disable, and pop then to actually change the code?
That would change four source files due to the fact that the "missing" destructor is inherited :-((. And the destructors have to be implemented for gcc anyway. And taking a second look it would probably be the best solution to just implement (empty) virtual destructors for all platforms. And just because #ifdef considered harmful :)) But I'd rather have the maintainer do the right thing :-)) Yours, Jürgen -- * Dipl.-Math. Jürgen Hunold ! Ingenieurgesellschaft für * voice: ++49 511 262926 57 ! Verkehrs- und Eisenbahnwesen mbH * fax : ++49 511 262926 99 ! Lister Straße 15 * juergen.hunold@ivembh.de ! www.ivembh.de * * Geschäftsführer: ! Sitz des Unternehmens: Hannover * Prof. Dr.-Ing. Thomas Siefer ! Amtsgericht Hannover, HRB 56965 * PD Dr.-Ing. Alfons Radtke !

On Tue, Aug 19, 2008 at 12:27 AM, Jürgen Hunold <juergen.hunold@ivembh.de> wrote:
Hi !
My coworkers found some more annoying msv 4265 warnings. (missing virtual destructor. The attached patch adds the necessary workaround (analog to gcc).
Okay to commit ?
Yes, thanks. Emil Dotchevski Reverge Studios, Inc. http://www.revergestudios.com/reblog/index.php?n=ReCode

Hi Emil ! On Wednesday 20 August 2008 00:51:31 Emil Dotchevski wrote:
On Tue, Aug 19, 2008 at 12:27 AM, Jürgen Hunold
Okay to commit ?
Yes, thanks.
Done : http://svn.boost.org/trac/boost/changeset/48248 Remains the query who will merge when to the release branch... Yours, Jürgen -- * Dipl.-Math. Jürgen Hunold ! Ingenieurgesellschaft für * voice: ++49 511 262926 57 ! Verkehrs- und Eisenbahnwesen mbH * fax : ++49 511 262926 99 ! Lister Straße 15 * juergen.hunold@ivembh.de ! www.ivembh.de * * Geschäftsführer: ! Sitz des Unternehmens: Hannover * Prof. Dr.-Ing. Thomas Siefer ! Amtsgericht Hannover, HRB 56965 * PD Dr.-Ing. Alfons Radtke !

On Wed, Aug 20, 2008 at 2:40 AM, Juergen Hunold <juergen.hunold@ivembh.de> wrote:
Hi Emil !
On Wednesday 20 August 2008 00:51:31 Emil Dotchevski wrote:
On Tue, Aug 19, 2008 at 12:27 AM, Jürgen Hunold
Okay to commit ?
Yes, thanks.
Done : http://svn.boost.org/trac/boost/changeset/48248
Remains the query who will merge when to the release branch...
I'll take care of that. Emil Dotchevski Reverge Studios, Inc. http://www.revergestudios.com/reblog/index.php?n=ReCode
participants (4)
-
Emil Dotchevski
-
Juergen Hunold
-
Jürgen Hunold
-
Michael Marcin