[1.51, heap] permission to merge r80039
request for release manager: i'd like to merge r80039 to release, as it fixes bug #7233. ok or too late? thanks, tim
On Aug 15, 2012, at 1:55 AM, Tim Blechmann <tim@klingt.org> wrote:
request for release manager:
i'd like to merge r80039 to release, as it fixes bug #7233. ok or too late?
The release branch is still open for bug (and doc) fixes. Today is the last day, though. -- Marshall Marshall Clow Idio Software <mailto:mclow.lists@gmail.com> A.D. 1517: Martin Luther nails his 95 Theses to the church door and is promptly moderated down to (-1, Flamebait). -- Yu Suzuki
On 8/15/2012 6:24 AM, Marshall Clow wrote:
On Aug 15, 2012, at 1:55 AM, Tim Blechmann <tim@klingt.org> wrote:
request for release manager:
i'd like to merge r80039 to release, as it fixes bug #7233. ok or too late?
The release branch is still open for bug (and doc) fixes. Today is the last day, though.
Marshall, this change was made on trunk 9 hours ago. That's not nearly enough time for tests to cycle. I'm not overruling you. Your decision stands. But in the future, we (the release managers) really need to stick to the script. Changes must be tested on trunk before they can be merged to release. And a similar heads-up to all boost developers: code changes this late in the game will not make the cut if they aren't tested. -- Eric Niebler BoostPro Computing http://www.boostpro.com
request for release manager:
i'd like to merge r80039 to release, as it fixes bug #7233. ok or too late?
The release branch is still open for bug (and doc) fixes. Today is the last day, though.
Marshall, this change was made on trunk 9 hours ago. That's not nearly enough time for tests to cycle.
I'm not overruling you. Your decision stands. But in the future, we (the release managers) really need to stick to the script. Changes must be tested on trunk before they can be merged to release.
And a similar heads-up to all boost developers: code changes this late in the game will not make the cut if they aren't tested.
this specific bug has been reported this morning and the fix is rather trivial. not merging the fix means that there is a known bug in the release, which is unfortunate as well. would be less of a problem, if we'd have regular (monthly?) bugfix releases, but that won't work well with the current two-branch branching model. tim
On 8/15/2012 3:28 PM, Tim Blechmann wrote:
request for release manager:
i'd like to merge r80039 to release, as it fixes bug #7233. ok or too late?
The release branch is still open for bug (and doc) fixes. Today is the last day, though.
Marshall, this change was made on trunk 9 hours ago. That's not nearly enough time for tests to cycle.
I'm not overruling you. Your decision stands. But in the future, we (the release managers) really need to stick to the script. Changes must be tested on trunk before they can be merged to release.
And a similar heads-up to all boost developers: code changes this late in the game will not make the cut if they aren't tested.
this specific bug has been reported this morning and the fix is rather trivial. not merging the fix means that there is a known bug in the release, which is unfortunate as well. would be less of a problem, if we'd have regular (monthly?) bugfix releases, but that won't work well with the current two-branch branching model.
I don't have a fundamental issue with shipping a release with known bugs. In fact, I don't think boost has ever gone out the door without heaps (no pun intended) of known bugs -- just check trac. Taking a fix is taking a risk. You could break something more fundamental, maybe on a platform you don't have access to, or maybe in a downstream library you didn't test locally. Some bugs are serious enough to justify the risk this late in the cycle. Most are not. That's why we have our release policies in place. IMO, it's not too onerous to require that testers have had a chance to cycle on changes in trunk before they get merged to release. It's a low bar. If somebody wants the release managers to make an exception for a particularly serious bug, they can make their case. We're reasonable people, and we *do* have the quality of the release in mind. Promise. :-) I agree, point releases would be nice. That's a different discussion. Thanks for your understanding, -- Eric Niebler BoostPro Computing http://www.boostpro.com
On 15 August 2012 23:40, Eric Niebler <eric@boostpro.com> wrote:
I don't have a fundamental issue with shipping a release with known bugs. In fact, I don't think boost has ever gone out the door without heaps (no pun intended) of known bugs -- just check trac. Taking a fix is taking a risk. You could break something more fundamental, maybe on a platform you don't have access to, or maybe in a downstream library you didn't test locally. Some bugs are serious enough to justify the risk this late in the cycle. Most are not. That's why we have our release policies in place. IMO, it's not too onerous to require that testers have had a chance to cycle on changes in trunk before they get merged to release. It's a low bar. If somebody wants the release managers to make an exception for a particularly serious bug, they can make their case.
If a bug is considered serious enough, we should delay the release by a few days, rather than rush the fix. The problem is that everyone considers their bug to be particularly serious, and bug reports keep coming in. We need to balance that value of that fix against the cost of delaying the fixes that ready for release. The tests seem to be running more frequently recently (esp. on windows), which does make it easier to get things in on time. Btw. if anyone has a patch that doesn't make it, I can add it to the release notes as I did for unordered in 1.50. I'm not sure if anyone made use of it, but at least it was published.
On Aug 15, 2012, at 10:55 AM, Eric Niebler <eric@boostpro.com> wrote:
On 8/15/2012 6:24 AM, Marshall Clow wrote:
On Aug 15, 2012, at 1:55 AM, Tim Blechmann <tim@klingt.org> wrote:
request for release manager:
i'd like to merge r80039 to release, as it fixes bug #7233. ok or too late?
The release branch is still open for bug (and doc) fixes. Today is the last day, though.
Marshall, this change was made on trunk 9 hours ago. That's not nearly enough time for tests to cycle.
I'm not overruling you. Your decision stands. But in the future, we (the release managers) really need to stick to the script. Changes must be tested on trunk before they can be merged to release.
And a similar heads-up to all boost developers: code changes this late in the game will not make the cut if they aren't tested.
Sorry - I misread the checkin date; I thought that it had been checked in before last night. -- Marshall Marshall Clow Idio Software <mailto:mclow.lists@gmail.com> A.D. 1517: Martin Luther nails his 95 Theses to the church door and is promptly moderated down to (-1, Flamebait). -- Yu Suzuki
participants (4)
-
Daniel James -
Eric Niebler -
Marshall Clow -
Tim Blechmann