[Boost-bugs] [ boost-Patches-1557285 ] opaque_pointer bug fix + enhancement

Patches item #1557285, was opened at 2006-09-12 12:06 Message generated for change (Settings changed) made by david_abrahams You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=307586&aid=1557285&group_id=7586 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None
Status: Closed Resolution: Fixed Priority: 5 Private: No Submitted By: Gottfried Gan�auge (ganssauge) Assigned to: David Abrahams (david_abrahams) Summary: opaque_pointer bug fix + enhancement
Initial Comment: After debugging a crash I found out that all instances created from opaque_pointer_converter had a type object which itself didn't have a type, and this finally lead to the crash. The attached patch corrects this behaviour by initialising the type object using PyType_Ready(). Furthermore I implemented cross module support in so far as the converter registers itself only if not another module already has registered the same converter before. The opaque test case has been update to check for the segmentation fault mentioned in my previous post. A test case for the cross module support is included (crossmod_opaque). I also updated the documentation for opaque. I tested my patch with - GCC-4.1 running on GNU/Linux 2.6.16.21-0.13-default x86_64 - Visual-C++-6.5 running on Windows XP - Visual-C++-7.1 running on Windows XP The patch is applied by calling patch -p1 < opaque_patch in the root of the boost hierarchy. Files patched are: boost_head/boost/python/opaque_pointer_converter.hpp boost_head/libs/python/doc/v2/opaque.html boost_head/libs/python/doc/v2/opaque_pointer_converter.html boost_head/libs/python/doc/v2/reference.html boost_head/libs/python/doc/v2/return_opaque_pointer.html boost_head.orig/libs/python/test/crossmod_opaque_a.cpp boost_head/libs/python/test/crossmod_opaque_a.cpp boost_head/libs/python/test/crossmod_opaque_b.cpp boost_head/libs/python/test/crossmod_opaque.py boost_head/libs/python/test/Jamfile boost_head/libs/python/test/Jamfile.v2 boost_head/libs/python/test/opaque.py ---------------------------------------------------------------------- Comment By: Gottfried Gan�auge (ganssauge) Date: 2006-09-18 09:02 Message: Logged In: YES user_id=792746 it has been applied to CVS Head ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=307586&aid=1557285&group_id=7586 ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Boost-bugs mailing list Boost-bugs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/boost-bugs
participants (1)
-
SourceForge.net