[filesystem] strange filenames created by tests confuse svn client
[this message is about the release branch, but it likely applies to the trunk as well] Hello, in boost/status/ there are files with strange names. I suspect these have been created by some test belonging to Boost.Filesystem. I further suspect that these tests assume a certain character encoding. The problem is that the subversion client looks at these filenames and produces error messages like svn: Can't convert string from native encoding to 'UTF-8': svn: fstream_test_?\226?\158?\128 The directory listing displays a lot of strange looking things: drwxr-xr-x 2 boost boost 72 Oct 9 05:21 boo -rw-r--r-- 1 boost boost 365 Oct 9 05:20 boost_dynamic_bitset_tests -rw-r--r-- 1 boost boost 395 Oct 7 14:43 borland_logo.gif -rw-r--r-- 1 boost boost 335 Oct 9 05:32 cube-fr.dot -rw-r--r-- 1 boost boost 333 Oct 9 05:32 cube.dot -rw-r--r-- 1 boost boost 3697 Oct 9 07:30 demo_save.xml -rw-r--r-- 1 boost boost 388 Oct 9 07:29 demofile.txt -rw-r--r-- 1 boost boost 353 Oct 9 05:32 disconnected-fr.dot -rw-r--r-- 1 boost boost 82 Oct 9 06:33 filename drwxr-xr-x 2 boost boost 72 Oct 9 05:21 foo -rw-r--r-- 1 boost boost 0 Oct 9 05:21 fsream_test_lpath -rw-r--r-- 1 boost boost 0 Oct 9 05:21 fstream_test_foo -rw-r--r-- 1 boost boost 0 Oct 9 05:21 fstream_test_??? -rw-r--r-- 1 boost boost 1249 Oct 7 14:43 intel_logo.gif -rw-r--r-- 1 boost boost 553 Oct 7 14:43 kai_logo.gif -rw-r--r-- 1 boost boost 956 Oct 9 05:32 kevin-bacon2.dat -rw-r--r-- 1 boost boost 763 Oct 7 14:43 ms_logo.gif -rw-r--r-- 1 boost boost 2348 Oct 7 14:43 notes.html -rw-r--r-- 1 boost boost 0 Oct 9 07:53 pattern.temp2 -rw-r--r-- 1 boost boost 15 Oct 9 07:53 pattern.test -rw-r--r-- 1 boost boost 450 Oct 9 05:32 random.dot -rw-r--r-- 1 boost boost 9 Oct 9 06:42 rng.saved -rw-r--r-- 1 boost boost 28 Oct 9 05:11 temp.tmp -rw-r--r-- 1 boost boost 46 Oct 9 07:28 test.dat -rw-r--r-- 1 boost boost 46 Oct 9 07:28 test2.dat -rw-r--r-- 1 boost boost 636 Oct 9 07:28 test3.dat -rw-r--r-- 1 boost boost 12 Oct 9 05:17 test_facet_file.out -rw-r--r-- 1 boost boost 8 Oct 9 07:28 testfile2 -rw-r--r-- 1 boost boost 49 Oct 9 07:04 testfile_binary_archive.hpp -rw-r--r-- 1 boost boost 36 Oct 9 07:04 testfile_text_archive.hpp -rw-r--r-- 1 boost boost 144 Oct 9 07:04 testfile_text_warchive.hpp -rw-r--r-- 1 boost boost 296 Oct 9 07:04 testfile_xml_archive.hpp -rw-r--r-- 1 boost boost 296 Oct 9 07:05 testfile_xml_warchive.hpp -rw-r--r-- 1 boost boost 186 Oct 9 05:20 tmp_file -rw-r--r-- 1 boost boost 454 Oct 9 05:32 triangular-fr.dot -rw-r--r-- 1 boost boost 455 Oct 9 05:32 triangular-kk.dot -rw-r--r-- 1 boost boost 655840 Oct 9 04:57 wave_slex_lexer.dfa -rw-r--r-- 1 boost boost 5690 Oct 7 14:43 win32-notes-map.txt drwxr-xr-x 3 boost boost 96 Oct 9 05:21 xx drwxr-xr-x 2 boost boost 72 Oct 9 05:21 ??? This directory is used for maintaining test-related stuff, e.g. the list of expected failures. IMO, the same directory shouldn't be a target for automatically generated files which do not contain anything meaningful. Please, could these files and directories (in order of preference): 1. be created elsewhere and 2. be deleted automatically after tests, or 3. be added to the svn:ignore property of the directory? Regards, m
Martin Wille wrote:
[this message is about the release branch, but it likely applies to the trunk as well]
The problem is already fixed in the trunk, so those fixes will migrate to the release branch once filesystem gets merged into the release branch.
in boost/status/ there are files with strange names. I suspect these have been created by some test belonging to Boost.Filesystem.
I further suspect that these tests assume a certain character encoding.
The problem is that the subversion client looks at these filenames and produces error messages like
svn: Can't convert string from native encoding to 'UTF-8': svn: fstream_test_?\226?\158?\128
...
This directory is used for maintaining test-related stuff, e.g. the list of expected failures. IMO, the same directory shouldn't be a target for automatically generated files which do not contain anything meaningful.
Please, could these files and directories (in order of preference):
1. be created elsewhere and
Any suggestions? I'd like to avoid entangling the test code with the details of the regression testing system.
2. be deleted automatically after tests, or
That's already been done. See revision 39365, September 18, 2007
3. be added to the svn:ignore property of the directory?
Not sure that is necessary, but feel free to submit a patch. Thanks, --Beman
Beman Dawes wrote:
Martin Wille wrote:
[this message is about the release branch, but it likely applies to the trunk as well]
The problem is already fixed in the trunk, so those fixes will migrate to the release branch once filesystem gets merged into the release branch.
Fine.
Please, could these files and directories (in order of preference):
1. be created elsewhere and
Any suggestions? I'd like to avoid entangling the test code with the details of the regression testing system.
It would probably be best if a suitable directory would be passed into the test(s) from the outside, e.g. through an environment variable set either by Boost.Build or by the test runner. BTW, the same scheme would also solve the problem of the serialization tests that leave a long list of files in /tmp every time they run.
2. be deleted automatically after tests, or
That's already been done. See revision 39365, September 18, 2007
That probably only applies to Boost.Filesystem, not to other libraries. Right?
3. be added to the svn:ignore property of the directory?
Not sure that is necessary, but feel free to submit a patch.
It isn't necessary when the temporary files get created elsewhere. Regards, m
participants (2)
-
Beman Dawes -
Martin Wille