[1.37] Merge permission sought (not a repost :-)
Hallo, I'd like to merge the attached patch to release. May I proceed? Thanks! Nicola -- Nicola.Musatti <at> gmail <dot> com Home: http://nicola.musatti.googlepages.com/home Blog: http://wthwdik.wordpress.com/ Index: float_functions.hpp =================================================================== --- float_functions.hpp (revision 49317) +++ float_functions.hpp (working copy) @@ -60,7 +60,7 @@ # endif // Dinkumware. -#elif (defined(_YVALS) && !defined(__IBMCPP__)) || defined(_CPPLIB_VER) +#elif ((defined(_YVALS) && !defined(__IBMCPP__)) || defined(_CPPLIB_VER)) && !defined(__BORLANDC__) // Some versions of Visual C++ don't seem to have the C++ overloads but they // all seem to have the c99 float overloads # if defined(BOOST_MSVC)
On Mon, Oct 13, 2008 at 4:30 PM, Nicola Musatti <Nicola.Musatti@gmail.com>wrote:
Hallo, I'd like to merge the attached patch to release. May I proceed?
Thanks! Nicola
Please double check that the && is correct, and then go ahead. --Beman
-- Nicola.Musatti <at> gmail <dot> com Home: http://nicola.musatti.googlepages.com/home Blog: http://wthwdik.wordpress.com/
Index: float_functions.hpp =================================================================== --- float_functions.hpp (revision 49317) +++ float_functions.hpp (working copy) @@ -60,7 +60,7 @@ # endif
// Dinkumware. -#elif (defined(_YVALS) && !defined(__IBMCPP__)) || defined(_CPPLIB_VER) +#elif ((defined(_YVALS) && !defined(__IBMCPP__)) || defined(_CPPLIB_VER)) && !defined(__BORLANDC__) // Some versions of Visual C++ don't seem to have the C++ overloads but they // all seem to have the c99 float overloads # if defined(BOOST_MSVC)
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
2008/10/13 Nicola Musatti <Nicola.Musatti@gmail.com>:
// Dinkumware. -#elif (defined(_YVALS) && !defined(__IBMCPP__)) || defined(_CPPLIB_VER) +#elif ((defined(_YVALS) && !defined(__IBMCPP__)) || defined(_CPPLIB_VER)) && !defined(__BORLANDC__) // Some versions of Visual C++ don't seem to have the C++ overloads but they // all seem to have the c99 float overloads # if defined(BOOST_MSVC)
Why is this needed? As far as I can tell, it shouldn't make any difference (for codegear, BOOST_MSVC shouldn't be defined and _CPPLIB_VER should be defined and greater than 402). If it does make a difference, it might be a bug. Daniel
Hallo, Daniel. You appear to be right! I'm not sure what changed since I found this patch was needed and I need to look into it. Still I expect I won't need to apply it after all. Cheers, Nicola Musatti Daniel James wrote:
2008/10/13 Nicola Musatti <Nicola.Musatti@gmail.com>:
// Dinkumware. -#elif (defined(_YVALS) && !defined(__IBMCPP__)) || defined(_CPPLIB_VER) +#elif ((defined(_YVALS) && !defined(__IBMCPP__)) || defined(_CPPLIB_VER)) && !defined(__BORLANDC__) // Some versions of Visual C++ don't seem to have the C++ overloads but they // all seem to have the c99 float overloads # if defined(BOOST_MSVC)
Why is this needed? As far as I can tell, it shouldn't make any difference (for codegear, BOOST_MSVC shouldn't be defined and _CPPLIB_VER should be defined and greater than 402). If it does make a difference, it might be a bug.
Daniel _______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
-- Nicola.Musatti <at> gmail <dot> com Home: http://nicola.musatti.googlepages.com/home Blog: http://wthwdik.wordpress.com/
2008/10/14 Nicola Musatti <Nicola.Musatti@gmail.com>:
Hallo, Daniel. You appear to be right! I'm not sure what changed since I found this patch was needed and I need to look into it. Still I expect I won't need to apply it after all.
I just realised what changed. It was broken for about a week on Borland. I fixed it here: http://svn.boost.org/trac/boost/changeset/48674/
Daniel James wrote:
2008/10/14 Nicola Musatti <Nicola.Musatti@gmail.com>:
Hallo, Daniel. You appear to be right! I'm not sure what changed since I found this patch was needed and I need to look into it. Still I expect I won't need to apply it after all.
I just realised what changed. It was broken for about a week on Borland. I fixed it here:
Glad to see I didn't dream it. Thanks! Cheers, Nicola -- Nicola.Musatti <at> gmail <dot> com Home: http://nicola.musatti.googlepages.com/home Blog: http://wthwdik.wordpress.com/
participants (3)
-
Beman Dawes -
Daniel James -
Nicola Musatti