Change 45393 breaks Boost.Thread on WinCE
Hi, I've been looking at the current failures on trunk for Boost.Thread, and one platform that's failing a lot is VeecoFTC's msvc- 8.0~wm5~stlport5.1. Further investigation reveals that this is due to the lack of boost::date_time::microsec_clock, which is no longer present for this compiler since change 45393. The comment for the change says "Disable BOOST_HAS_FTIME on WinCE.", and the comment in the code says "GetSystemTimeAsFileTime not present on WinCE." Though the comment in the code is correct, there is already a macro for that in boost/config/compiler/visualc.hpp: BOOST_NO_GETSYSTEMTIMEASFILETIME WinCE *does* have FILETIME, and boost::date_time::microsec_clock uses it successfully on WinCE, with a workaround for the lack of GetSystemTimeAsFileTime. Please can we revert this change. Anthony -- Anthony Williams | Just Software Solutions Ltd Custom Software Development | http://www.justsoftwaresolutions.co.uk Registered in England, Company Number 5478976. Registered Office: 15 Carrallack Mews, St Just, Cornwall, TR19 7UL
Anthony Williams:
Though the comment in the code is correct, there is already a macro for that in boost/config/compiler/visualc.hpp: BOOST_NO_GETSYSTEMTIMEASFILETIME
FWIW, this macro breaks the convention that the BOOST_NO_* prefix is reserved for defects, whereas BOOST_HAS_* is for features. This of course doesn't make the change you object to correct.
"Peter Dimov" <pdimov@pdimov.com> writes:
Anthony Williams:
Though the comment in the code is correct, there is already a macro for that in boost/config/compiler/visualc.hpp: BOOST_NO_GETSYSTEMTIMEASFILETIME
FWIW, this macro breaks the convention that the BOOST_NO_* prefix is reserved for defects, whereas BOOST_HAS_* is for features.
I guess whoever added the macro thought it appropriate: WinCE is different to normal win32 platforms in that it is missing certain functions. I don't mind either way. John's added a trac ticket for the naming issue: 1988. Anthony -- Anthony Williams | Just Software Solutions Ltd Custom Software Development | http://www.justsoftwaresolutions.co.uk Registered in England, Company Number 5478976. Registered Office: 15 Carrallack Mews, St Just, Cornwall, TR19 7UL
Peter Dimov wrote:
Anthony Williams:
Though the comment in the code is correct, there is already a macro for that in boost/config/compiler/visualc.hpp: BOOST_NO_GETSYSTEMTIMEASFILETIME
FWIW, this macro breaks the convention that the BOOST_NO_* prefix is reserved for defects, whereas BOOST_HAS_* is for features. This of course doesn't make the change you object to correct.
Yep, and also got added without tests or docs which is why I missed it, I've opened a trac issue on it. John.
participants (3)
-
Anthony Williams -
John Maddock -
Peter Dimov