Can someone (using Windows) check ticket #316?
It's hard to tell, but those look like Visual Studio warnings. If they no longer exist, that ticket should be closed. If they do still exist, they should be looked into. <https://svn.boost.org/trac/boost/ticket/316> Thanks! -- -- Marshall Marshall Clow Idio Software <mailto:marshall@idio.com> It is by caffeine alone I set my mind in motion. It is by the beans of Java that thoughts acquire speed, the hands acquire shaking, the shaking becomes a warning. It is by caffeine alone I set my mind in motion.
AMDG Marshall Clow wrote:
It's hard to tell, but those look like Visual Studio warnings. If they no longer exist, that ticket should be closed. If they do still exist, they should be looked into.
I've got this. In Christ, Steven Watanabe
AMDG Marshall Clow wrote:
It's hard to tell, but those look like Visual Studio warnings. If they no longer exist, that ticket should be closed. If they do still exist, they should be looked into.
This appears to be the same as https://svn.boost.org/trac/boost/ticket/287 so it will only be triggered when BOOST_DATE_TIME_NO_LOCALE is defined. The use of narrow in the else branch is still wrong... In Christ, Steven Watanabe
At 5:51 PM -0700 5/30/09, Steven Watanabe wrote:
AMDG
Marshall Clow wrote:
It's hard to tell, but those look like Visual Studio warnings. If they no longer exist, that ticket should be closed. If they do still exist, they should be looked into.
This appears to be the same as https://svn.boost.org/trac/boost/ticket/287 so it will only be triggered when BOOST_DATE_TIME_NO_LOCALE is defined. The use of narrow in the else branch is still wrong...
What would be a good fix there (in #287) in the case where you can't use the locale? -- -- Marshall Marshall Clow Idio Software <mailto:marshall@idio.com> It is by caffeine alone I set my mind in motion. It is by the beans of Java that thoughts acquire speed, the hands acquire shaking, the shaking becomes a warning. It is by caffeine alone I set my mind in motion.
AMDG Marshall Clow wrote:
At 5:51 PM -0700 5/30/09, Steven Watanabe wrote:
The use of narrow in the else branch is still wrong...
What would be a good fix there (in #287) in the case where you can't use the locale?
The code that's there now is equivalent to cast and hope for the best, since calling narrow should have no effect once we've already implicitly converted to char. I can think of two alternatives: std::wostream dummy; ss << dummy.narrow(*beg++, 'X'); or ss << boost::numeric_cast<char>(*beg++); In Christ, Steven Watanabe
participants (2)
-
Marshall Clow -
Steven Watanabe