Invalid include in half_open_range.hpp
...breaks half_open_range_test (utility) on all compilers. OK to commit? Stefan Index: half_open_range.hpp =================================================================== RCS file: /cvsroot/boost/boost/boost/half_open_range.hpp,v retrieving revision 1.5 diff -u -r1.5 half_open_range.hpp --- half_open_range.hpp 26 Jul 2004 00:31:58 -0000 1.5 +++ half_open_range.hpp 4 Aug 2004 14:21:29 -0000 @@ -12,7 +12,7 @@ #ifndef BOOST_HALF_OPEN_RANGE_HPP_ # define BOOST_HALF_OPEN_RANGE_HPP_ -# include <boost/counting_iterator.hpp> +# include <boost/iterator/counting_iterator.hpp> # include <functional> # include <cassert> # include <boost/operators.hpp>
I've just seen that there is something different wrong with this file: it uses a type counting_iterator_generator which is defined nowhere in the whole boost library. What's up with this header? Stefan Stefan Slapeta wrote:
...breaks half_open_range_test (utility) on all compilers.
OK to commit?
Stefan
------------------------------------------------------------------------
Index: half_open_range.hpp =================================================================== RCS file: /cvsroot/boost/boost/boost/half_open_range.hpp,v retrieving revision 1.5 diff -u -r1.5 half_open_range.hpp --- half_open_range.hpp 26 Jul 2004 00:31:58 -0000 1.5 +++ half_open_range.hpp 4 Aug 2004 14:21:29 -0000 @@ -12,7 +12,7 @@ #ifndef BOOST_HALF_OPEN_RANGE_HPP_ # define BOOST_HALF_OPEN_RANGE_HPP_
-# include <boost/counting_iterator.hpp> +# include <boost/iterator/counting_iterator.hpp> # include <functional> # include <cassert> # include <boost/operators.hpp>
------------------------------------------------------------------------
_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
On Aug 4, 2004, at 9:37 AM, Stefan Slapeta wrote:
I've just seen that there is something different wrong with this file: it uses a type counting_iterator_generator which is defined nowhere in the whole boost library. What's up with this header?
It predates the new iterator adaptors library (which isn't so "new" any more!) . It must have been broken in 1.31.0 and isn't used or documented anywhere in Boost... sounds like a candidate for removal. Doug
Stefan Slapeta wrote:
Doug Gregor wrote:
It predates the new iterator adaptors library (which isn't so "new" any more!) . It must have been broken in 1.31.0 and isn't used or documented anywhere in Boost... sounds like a candidate for removal.
Nice, but _who_ removes _what_ now?
I've now commented the test case in the jamfile. What are the plans for this non-compiling header file (half_open_range.hpp)? Stefan
On Thursday 05 August 2004 1:48 pm, Stefan Slapeta wrote:
Stefan Slapeta wrote:
Doug Gregor wrote:
It predates the new iterator adaptors library (which isn't so "new" any more!) . It must have been broken in 1.31.0 and isn't used or documented anywhere in Boost... sounds like a candidate for removal.
Nice, but _who_ removes _what_ now?
I've now commented the test case in the jamfile. What are the plans for this non-compiling header file (half_open_range.hpp)?
I've just removed the header, test file, and updated both testing Jamfiles. We'll just see if anyone complains :) Doug
Stefan Slapeta <stefan@slapeta.com> writes:
...breaks half_open_range_test (utility) on all compilers.
OK to commit?
Yes, though it's not clear to me that the test should even be there -- this isn't an officially accepted library and I think some recent work will probably supplant it.
Stefan
Index: half_open_range.hpp =================================================================== RCS file: /cvsroot/boost/boost/boost/half_open_range.hpp,v retrieving revision 1.5 diff -u -r1.5 half_open_range.hpp --- half_open_range.hpp 26 Jul 2004 00:31:58 -0000 1.5 +++ half_open_range.hpp 4 Aug 2004 14:21:29 -0000 @@ -12,7 +12,7 @@ #ifndef BOOST_HALF_OPEN_RANGE_HPP_ # define BOOST_HALF_OPEN_RANGE_HPP_
-# include <boost/counting_iterator.hpp> +# include <boost/iterator/counting_iterator.hpp> # include <functional> # include <cassert> # include <boost/operators.hpp>_______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
-- Dave Abrahams Boost Consulting http://www.boost-consulting.com
participants (3)
-
David Abrahams -
Doug Gregor -
Stefan Slapeta