vc-8_0-amd64 toolset patch for VS 2005 Beta 2

I have attached a simple patch to the file boost/tools/build/v1/vc-8_0-amd64-tools.jam that accounts for an apparent name change to a .bat file in the Visual Studio 2005 Beta 2 install tree. I say "apparent name change" because I am assuming that the .jam file was made with Visual Studio 2005 Beta 1, with which I have no experience. If I am doing something wrong in trying to build Boost to target the AMD64 architecture on Windows which would make this patch useless, please let me know. -Patrick -- Patrick L. Hartling | VP Engineering, Infiscape Corp. PGP: http://tinyurl.com/2oum9 | http://www.infiscape.com/ ? bin ? boost-amd6.patch Index: tools/build/v1/vc-8_0-amd64-tools.jam =================================================================== RCS file: /cvsroot/boost/boost/tools/build/v1/vc-8_0-amd64-tools.jam,v retrieving revision 1.1 diff -u -r1.1 vc-8_0-amd64-tools.jam --- tools/build/v1/vc-8_0-amd64-tools.jam 16 Mar 2005 13:09:15 -0000 1.1 +++ tools/build/v1/vc-8_0-amd64-tools.jam 6 Jun 2005 17:59:01 -0000 @@ -9,14 +9,14 @@ { VC80_ROOT ?= $(VS80COMNTOOLS:J=" ")..\\..\\VC ; VC_TOOL_PATH = "$(VC80_ROOT)"\\bin\\amd64\\ ; - VC_SETUP = "CALL \"$(VC_TOOL_PATH)vcvars_64.BAT\" >nul" ; + VC_SETUP = "CALL \"$(VC_TOOL_PATH)vcvarsamd64.BAT\" >nul" ; } else { ProgramFiles ?= $(PROGRAMFILES) ; VC80_ROOT ?= $(ProgramFiles:J=" ")"\\Microsoft Visual Studio 8\\VC" ; VC_TOOL_PATH = "$(VC80_ROOT)"\\bin\\amd64\\ ; - VC_SETUP = "CALL \"$(VC_TOOL_PATH)vcvars_64.BAT\" >nul" ; + VC_SETUP = "CALL \"$(VC_TOOL_PATH)vcvarsamd64.BAT\" >nul" ; } }

Patrick Hartling <patrick@137.org> writes:
I have attached a simple patch to the file boost/tools/build/v1/vc-8_0-amd64-tools.jam that accounts for an apparent name change to a .bat file in the Visual Studio 2005 Beta 2 install tree. I say "apparent name change" because I am assuming that the .jam file was made with Visual Studio 2005 Beta 1, with which I have no experience. If I am doing something wrong in trying to build Boost to target the AMD64 architecture on Windows which would make this patch useless, please let me know.
No, you didn't do anything wrong, but noticing the code duplication in your patch made me want to clean things up. Please try the latest CVS. The amount of copy/paste programming in these toolsets is truly scary. And it's leading to subtle and disconcerting variations in related toolsets. I tried to clean that up a little bit for the vc-8_0* toolsets, but vc-7_1* have the same problem. This stuff ought to be refactored... or retired. -- Dave Abrahams Boost Consulting www.boost-consulting.com

David Abrahams wrote:
Patrick Hartling <patrick@137.org> writes:
I have attached a simple patch to the file boost/tools/build/v1/vc-8_0-amd64-tools.jam that accounts for an apparent name change to a .bat file in the Visual Studio 2005 Beta 2 install tree. I say "apparent name change" because I am assuming that the .jam file was made with Visual Studio 2005 Beta 1, with which I have no experience. If I am doing something wrong in trying to build Boost to target the AMD64 architecture on Windows which would make this patch useless, please let me know.
No, you didn't do anything wrong, but noticing the code duplication in your patch made me want to clean things up. Please try the latest CVS.
It works like a charm. Thanks. -Patrick
The amount of copy/paste programming in these toolsets is truly scary. And it's leading to subtle and disconcerting variations in related toolsets. I tried to clean that up a little bit for the vc-8_0* toolsets, but vc-7_1* have the same problem. This stuff ought to be refactored... or retired.
-- Patrick L. Hartling | VP Engineering, Infiscape Corp. PGP: http://tinyurl.com/2oum9 | http://www.infiscape.com/
participants (2)
-
David Abrahams
-
Patrick Hartling