[inspect] added new check for C-style assert macro (was: [property_tree][showstopper][1.45] missing include in string_path.hpp)
On 11/11/2010 3:49 PM, Sebastian Redl wrote:
On 11.11.2010, at 21:38, Eric Niebler wrote:
If BOOST_ASSERT is *always* to be preferred over C's assert macro, then we should probably add that to the inspection report, right?
That would probably a good idea.
I just modified the inspect tool to check for the presence of C-style assert in Boost code. Everybody should be using BOOST_ASSERT. (Right?) Here's the result of running the new check over Boost trunk: http://pastebin.com/NttTw3BJ Beman, the inspection report looks like it was last run in June. What's up? http://boost.cowic.de/rc/inspect-trunk.html -- Eric Niebler BoostPro Computing http://www.boostpro.com
----- Original Message ----- From: "Daniel James" <dnljms@gmail.com> To: <boost@lists.boost.org> Sent: Friday, November 12, 2010 12:52 AM Subject: Re: [boost] [inspect] added new check for C-style assert macro (was: [property_tree][showstopper][1.45] missing include in string_path.hpp)
On 11 November 2010 23:08, Eric Niebler <eric@boostpro.com> wrote:
I just modified the inspect tool to check for the presence of C-style assert in Boost code. Everybody should be using BOOST_ASSERT. (Right?)
Not always, example code should use 'assert'.
+1. The check should be limited to the boost directory and the src subdirectories. Vicente
On 11/11/2010 7:11 PM, vicente.botet wrote:
On November 12, 2010 12:52 AM, Daniel James wrote:
On 11 November 2010 23:08, Eric Niebler <eric@boostpro.com> wrote:
I just modified the inspect tool to check for the presence of C-style assert in Boost code. Everybody should be using BOOST_ASSERT. (Right?)
Not always, example code should use 'assert'.
+1. The check should be limited to the boost directory and the src subdirectories.
OK, that's do-able. The inspect tool has been updated. Here is the new report: http://pastebin.com/k8RTG1sf -- Eric Niebler BoostPro Computing http://www.boostpro.com
On 11/11/2010 9:26 PM, Eric Niebler wrote:
The inspect tool has been updated.
I'd like to update boost's developer guidelines (http://www.boost.org/development/requirements.html) to reflect the changes to the inspect tool. In the website's svn repository, I see two directories: public_html/beta and public_html/live. Which do I change, and what's the procedure for keeping these two in sync? -- Eric Niebler BoostPro Computing http://www.boostpro.com
On 11/11/2010 8:35 PM, Eric Niebler wrote:
On 11/11/2010 9:26 PM, Eric Niebler wrote:
The inspect tool has been updated.
I'd like to update boost's developer guidelines (http://www.boost.org/development/requirements.html) to reflect the changes to the inspect tool. In the website's svn repository, I see two directories: public_html/beta and public_html/live. Which do I change, and what's the procedure for keeping these two in sync?
Like library coding.. 1. Update the beta first, and make sure it looks and functions OK. 2. Merge to live, and make sure that looks OK. Stuff about updating the HTML and structure are documented <http://www.boost.org/development/website_updating.html>. -- -- Grafik - Don't Assume Anything -- Redshift Software, Inc. - http://redshift-software.com -- rrivera/acm.org (msn) - grafik/redshift-software.com -- 102708583/icq - grafikrobot/aim,yahoo,skype,efnet,gmail
On 11/11/2010 9:55 PM, Rene Rivera wrote:
On 11/11/2010 8:35 PM, Eric Niebler wrote:
On 11/11/2010 9:26 PM, Eric Niebler wrote:
The inspect tool has been updated.
I'd like to update boost's developer guidelines (http://www.boost.org/development/requirements.html) to reflect the changes to the inspect tool. In the website's svn repository, I see two directories: public_html/beta and public_html/live. Which do I change, and what's the procedure for keeping these two in sync?
Like library coding..
1. Update the beta first, and make sure it looks and functions OK. 2. Merge to live, and make sure that looks OK.
By "merge" you mean just copy it, right? These aren't branches.
Stuff about updating the HTML and structure are documented <http://www.boost.org/development/website_updating.html>.
Thanks for the pointer. I didn't know about HTML Tidy. -- Eric Niebler BoostPro Computing http://www.boostpro.com
On 11/11/2010 9:58 PM, Eric Niebler wrote:
On 11/11/2010 9:55 PM, Rene Rivera wrote:
On 11/11/2010 8:35 PM, Eric Niebler wrote:
On 11/11/2010 9:26 PM, Eric Niebler wrote:
The inspect tool has been updated.
I'd like to update boost's developer guidelines (http://www.boost.org/development/requirements.html) to reflect the changes to the inspect tool. In the website's svn repository, I see two directories: public_html/beta and public_html/live. Which do I change, and what's the procedure for keeping these two in sync?
Like library coding..
1. Update the beta first, and make sure it looks and functions OK. 2. Merge to live, and make sure that looks OK.
By "merge" you mean just copy it, right? These aren't branches.
Originally live was a "branch" of beta, i.e. it was an "svn copy". But I guess I use a different definition than svn uses. I mean do a diff between them and copy over the changes you think are appropriate. Personally I use winmerge to do this. As I don't trust the "automated" merge features of any VC system. -- -- Grafik - Don't Assume Anything -- Redshift Software, Inc. - http://redshift-software.com -- rrivera/acm.org (msn) - grafik/redshift-software.com -- 102708583/icq - grafikrobot/aim,yahoo,skype,efnet,gmail
On 12 November 2010 04:15, Rene Rivera <grafikrobot@gmail.com> wrote:
Originally live was a "branch" of beta, i.e. it was an "svn copy". But I guess I use a different definition than svn uses. I mean do a diff between them and copy over the changes you think are appropriate. Personally I use winmerge to do this. As I don't trust the "automated" merge features of any VC system.
I do and it saves a lot of effort. Whenever anyone copies content across I manually add the merge information to keep it up to date. Daniel
On 11/12/2010 3:32 AM, Daniel James wrote:
On 12 November 2010 04:15, Rene Rivera <grafikrobot@gmail.com> wrote:
Originally live was a "branch" of beta, i.e. it was an "svn copy". But I guess I use a different definition than svn uses. I mean do a diff between them and copy over the changes you think are appropriate. Personally I use winmerge to do this. As I don't trust the "automated" merge features of any VC system.
I do and it saves a lot of effort. Whenever anyone copies content across I manually add the merge information to keep it up to date.
Oh. I copies requirements.html over by hand before I saw this. Sorry. -- Eric Niebler BoostPro Computing http://www.boostpro.com
On 12 November 2010 02:55, Rene Rivera <grafikrobot@gmail.com> wrote:
Stuff about updating the HTML and structure are documented <http://www.boost.org/development/website_updating.html>.
That's a bit out of date now, I've changed a few things. I've got some more changes coming up soon to make it easier to statically generate a lot of pages. So I'll update it then. Daniel
On 12 November 2010 02:35, Eric Niebler <eric@boostpro.com> wrote:
On 11/11/2010 9:26 PM, Eric Niebler wrote:
The inspect tool has been updated.
I'd like to update boost's developer guidelines (http://www.boost.org/development/requirements.html) to reflect the changes to the inspect tool. In the website's svn repository, I see two directories: public_html/beta and public_html/live. Which do I change, and what's the procedure for keeping these two in sync?
It's probably best if you just update live, and then I'll merge it back to beta. That's what the review managers do and it works pretty well. I use subversion's merge tracking to keep the two in sync, always merging at the root. Sometimes it gets confused by bidirectional merges, but it mostly works well. Daniel
participants (4)
-
Daniel James -
Eric Niebler -
Rene Rivera -
vicente.botet