El 21/05/2025 a las 9:39, Дмитрий Архипов via Boost escribió:
вт, 13 мая 2025 г. в 12:48, Arnaud Becheler via Boost <boost@lists.boost.org>:
Dear Boost community,
The review of the Boost.Bloom library begins today May 13th, 2025, and will run through May 22nd, 2025. This is my review of the proposed Boost.Bloom library.
Thanks Dmitry for your review!
First of all, I want to disclose that I work for the C++ Alliance. Also, I don't have any particular knowledge of probabilistic theory or container implementations. Between reading documentation and tinkering with the tests, examples, and benchmarks, I'd say I've spent around 6 hours.
[...] The API is small, but I looked at other libraries that implement Bloom filters and couldn't find anything that's missing. After thinking about it for several days I could only conceive of one possible extra operation: looking for several items at once may potentially be faster than doing it in sequence.
Yes, maybe we could potentially leverage the same technique used by Boost.Unordered concurrent container's bulk visitation: https://bannalia.blogspot.com/2023/10/bulk-visitation-in-boostconcurrentflat...
[...]
My only criticism of the documentation is that I don't believe it mentions why Bloom filters are called that. When I started doing my review I thought that there is some metaphorical connection between the container and flowers blooming.
This was also observed by Peter Turcan. I'll add a mention to that in the docs.
I am in general not a fan of one page documentation, but this one is short enough to work well in this format.
If the library is accepted, my plan is to ask Chris Mazakas for help to port the docs to multi-page Antora. Joaquin M Lopez Munoz