2010.03.29 18:59, Steven Watanabe rašė:
[skipped] I didn't look at it very closely, but I have a few notes: * bit_count. This appears to be equivalent to std::numeric_limits::digits? * validation is eventually going to die, since it isn't in the standard. It will be moved to the tests, since that's the only place that it is used. * I'm not sure that the extra constructor/seed overloads are a good idea. (Yes, I know I asked for it, but it seems to expose the implementation details, and I don't think it's all that useful without a corresponding way to get the state. The rationale that you gave for only having the default constructor seems reasonable.)
The interface has settled down and it even looks fine, i.e., I am finally happy with it. Many thanks to you, your comments were enormously useful. The last version is uploaded to Vault. (No doxygen comments yet.)
Would you be willing to write documentation for this as well?
I have written the concept part. J.