John Torjo wrote:
Someone else told me privately about these - I fixed them but did not commit. However, I've committed the changes now - please take the latest version from SVN.
Done, thanks. Here's the next batch: unsigned vs. signed comparisons: /usr/local/src/boost-logging/boost/logging/format/destination/rolling_file.hpp: In member function ‘void boost::logging::destination::detail::rolling_file_info<convert_dest>::restart() [with convert_dest = boost::logging::destination::do_convert_destination]’: /usr/local/src/boost-logging/boost/logging/format/destination/rolling_file.hpp:85: instantiated from ‘boost::logging::destination::detail::rolling_file_info<convert_dest>::rolling_file_info(const std::string&, boost::logging::destination::rolling_file_settings) [with convert_dest = boost::logging::destination::do_convert_destination]’ /usr/local/src/boost-logging/boost/logging/detail/manipulator.hpp:494: instantiated from ‘boost::logging::manipulator::non_const_context<context_type>::non_const_context(const p1&, const p2&) [with p1 = std::basic_string<char, std::char_traits<char>, std::allocator<char> >, p2 = boost::logging::destination::rolling_file_settings, context_type = boost::logging::destination::detail::rolling_file_info<boost::logging::destination::do_convert_destination>]’ /usr/local/src/boost-logging/boost/logging/format/destination/rolling_file.hpp:179: instantiated from ‘boost::logging::destination::rolling_file_t<convert_dest>::rolling_file_t(const std::string&, boost::logging::destination::rolling_file_settings) [with convert_dest = boost::logging::destination::do_convert_destination]’ /usr/local/src/boost-logging/boost/logging/writer/named_write.hpp:356: instantiated from ‘void boost::logging::writer::named_write<format_write_>::init() [with format_write_ = boost::logging::default_]’ /usr/local/src/boost-logging/boost/logging/writer/named_write.hpp:153: instantiated from ‘boost::logging::writer::named_write<format_write_>::named_write() [with format_write_ = boost::logging::default_]’ /usr/local/src/boost-logging/boost/logging/detail/logger.hpp:224: instantiated from ‘boost::logging::logger<gather_msg, write_msg>::logger() [with gather_msg = boost::logging::gather::ostream_like::return_str<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::basic_ostringstream<char, std::char_traits<char>, std::allocator<char> > >, write_msg = boost::logging::writer::named_write<boost::logging::default_>]’ /usr/local/src/boost-logging/boost/logging/detail/log_keeper.hpp:89: instantiated from ‘boost::logging::logger_holder_by_value<type>::logger_holder_by_value() [with type = boost::logging::logger<boost::logging::gather::ostream_like::return_str<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::basic_ostringstream<char, std::char_traits<char>, std::allocator<char> > >, boost::logging::writer::named_write<boost::logging::default_> >]’ log.cc:6: instantiated from here /usr/local/src/boost-logging/boost/logging/format/destination/rolling_file.hpp:101: warning: comparison between signed and unsigned integer expressions /usr/local/src/boost-logging/boost/logging/format/destination/rolling_file.hpp: In member function ‘void boost::logging::destination::detail::rolling_file_info<convert_dest>::recreate_file() [with convert_dest = boost::logging::destination::do_convert_destination]’: /usr/local/src/boost-logging/boost/logging/format/destination/rolling_file.hpp:114: instantiated from ‘void boost::logging::destination::detail::rolling_file_info<convert_dest>::restart() [with convert_dest = boost::logging::destination::do_convert_destination]’ /usr/local/src/boost-logging/boost/logging/format/destination/rolling_file.hpp:85: instantiated from ‘boost::logging::destination::detail::rolling_file_info<convert_dest>::rolling_file_info(const std::string&, boost::logging::destination::rolling_file_settings) [with convert_dest = boost::logging::destination::do_convert_destination]’ /usr/local/src/boost-logging/boost/logging/detail/manipulator.hpp:494: instantiated from ‘boost::logging::manipulator::non_const_context<context_type>::non_const_context(const p1&, const p2&) [with p1 = std::basic_string<char, std::char_traits<char>, std::allocator<char> >, p2 = boost::logging::destination::rolling_file_settings, context_type = boost::logging::destination::detail::rolling_file_info<boost::logging::destination::do_convert_destination>]’ /usr/local/src/boost-logging/boost/logging/format/destination/rolling_file.hpp:179: instantiated from ‘boost::logging::destination::rolling_file_t<convert_dest>::rolling_file_t(const std::string&, boost::logging::destination::rolling_file_settings) [with convert_dest = boost::logging::destination::do_convert_destination]’ /usr/local/src/boost-logging/boost/logging/writer/named_write.hpp:356: instantiated from ‘void boost::logging::writer::named_write<format_write_>::init() [with format_write_ = boost::logging::default_]’ /usr/local/src/boost-logging/boost/logging/writer/named_write.hpp:153: instantiated from ‘boost::logging::writer::named_write<format_write_>::named_write() [with format_write_ = boost::logging::default_]’ /usr/local/src/boost-logging/boost/logging/detail/logger.hpp:224: instantiated from ‘boost::logging::logger<gather_msg, write_msg>::logger() [with gather_msg = boost::logging::gather::ostream_like::return_str<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::basic_ostringstream<char, std::char_traits<char>, std::allocator<char> > >, write_msg = boost::logging::writer::named_write<boost::logging::default_>]’ /usr/local/src/boost-logging/boost/logging/detail/log_keeper.hpp:89: instantiated from ‘boost::logging::logger_holder_by_value<type>::logger_holder_by_value() [with type = boost::logging::logger<boost::logging::gather::ostream_like::return_str<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::basic_ostringstream<char, std::char_traits<char>, std::allocator<char> > >, boost::logging::writer::named_write<boost::logging::default_> >]’ log.cc:6: instantiated from here /usr/local/src/boost-logging/boost/logging/format/destination/rolling_file.hpp:131: warning: comparison between signed and unsigned integer expressions Phil.