Hi John,
However, I did notice that the empty-base-optimisation has been incorrectly applied - so for example sizeof(bounded_int<int, 0, 100>::type) is 8 when compiled with msvc (ie even with EBO support).
AFAICT the EBO support is tuned fine and on GCC it works as expected. I too was getting a bit worse results with MSVC, but I suspect this is rather the fault of MSVC. However, if I missed something, I'd be grateful for pointing me to the place which is the problem.
Also I'm a little surprised that there are no tests as yet: rather lets down an otherwise nice submission.
**** I believe the review manager should not allow full acceptance until a decent set of tests are provided ****
Conditional acceptance would be OK for me and wouldn't change anything, because I wouldn't submit the code to SVN without completing the regression tests anyway. I decided to do this after the review, because I want to make the tests having a stable interface (and the review is likely to change it).
But... no documentation on the concepts used by the library, and of course suitable concept archetypes should be used to test the library.
Which concepts do you have in mind -- the policies or things like CopyConstructible? The policies are described in the documentation of constrained class template. Did I miss something there?
A couple of hours reading docs, browsing source, and building a couple of examples.
Thank you for your time and your vote. ;-) Regards, Robert