Hi Daniel, On Sat, 02 Jan 2010 15:15 +0000, "Daniel James" <daniel_james@fmail.co.uk> wrote:
2010/1/1 Andy Tompkins <atompkins@fastmail.fm>:
I updated the documentation (added the markup - thank you, and reorganized). I also marked all the tests on a few platforms as expected failures (I hope I did it right).
It looks good to me.
Thanks.
I don't know what is wrong with the tests for sun-5.10 (http://tinyurl.com/yeuelll).
Looks like a compiler bug. It gets confused by passing an array and a pointer. Try the attached patch, it also fixes a minor bug (digits_end is incorrect in your current version and will return an unspecified result if c is '\0') and adds a small optimization to avoid checking the pointer. There isn't actually much point in using std::distance, you could just subtract, but I left that alone.
Thank you so much. I fixed the minor bug you pointed out, added the optimization. In the future I will remove std::distance.
The patch also contains a fix for the very slow test_generators on OS X. It turns out that every time you open '/dev/random' it initiates it, which is very slow. So the patch opens it once when seed_rng is created and reuses the same stream.
This is really great! I had no idea why the test was so slow.
Daniel
Thanks again so much! Andy Tompkins