2 Dec
2024
2 Dec
'24
9:47 p.m.
It's been a while with the reply etiquette and using gmail, apologies in advance. 1. is_endian_independent is a nice touch, something that's oft overlooked 2. Seems to be missing some other hashes like BLAKE, SHA3. 3. Do we have a checksum library with CRC32/32C/64/64NVME (the new one AWS S3 is using)? Do they belong here? 4. The benchmark seems like it uses a typical time-boxed chrono calculation. Is there really not a canned implementation of that somewhere? 5. Is the benchmark using sufficient content to avoid overwhelming cache optimization? 6. There's a header-only implementation of SHA1 in uuid (*iirc...), will we be moving to use this?