On Tuesday, January 21st, 2025 at 12:56 PM, Ivan Matek via Boost wrote:
On Tue, Jan 21, 2025 at 6:06 PM Peter Dimov pdimov@gmail.com wrote:
Basically, _fast types are almost never fast. Let's hope this curse doesn't
afflict Decimal _fast types as well. :-)
Thank you for confirming this, now I regret not writing that also in
review. :)
To recap the discussion wrt pass by reference:
points we agree on(wrt 64 bit x86):
- if we pass by value on Windows we are out of luck for most decimal
types since there is ABI limitation for types greater than 8 bytes
- use of uint16_fast_t in implementation pushed decimal64_fast over the
limit of Linux ABI(16 bytes), _fast std:: types are not fast, would be nice
to change this even if will not help on Windows
points we disagree on:
- pass by reference for large types (and if necessary mutate inplace) is
still my prefered API. If we do want value returning functions then for
large types I would prefer to pass args by const reference.
Not trying to change your mind, just recapping above discussion, doing all
sizeof and ABI math is tricky.
Here's a data point on macOS ARM64:
Benchmarks on Current Develop:
===== Comparisons =====
comparisons: 555534 us (s=29999985)
comparisons: 680204 us (s=29999985)
comparisons: 598125 us (s=29999985)
===== Addition =====
Addition: 1112121 us
Addition: 1282197 us
Addition: 6967490 us
===== Subtraction =====
Subtraction: 930937 us
Subtraction: 1127780 us
Subtraction: 3645142 us
===== Multiplication =====
Multiplication: 776308 us
Multiplication: 1145653 us
Multiplication: 17949983 us
===== Division =====
Division: 904825 us
Division: 1659034 us
Division: 1648759 us
Every uint_fastXX_t or int_fastXX replaced by uintXX_t or intXX_t:
===== Comparisons =====
comparisons: 586511 us
comparisons: 709211 us
comparisons: 657634 us
===== Addition =====
Addition: 1121786 us
Addition: 1289409 us
Addition: 7020519 us
===== Subtraction =====
Subtraction: 963632 us
Subtraction: 1160965 us
Subtraction: 3695792 us
===== Multiplication =====
Multiplication: 800159 us
Multiplication: 1179959 us
Multiplication: 18459046 us
===== Division =====
Division: 928643 us
Division: 1683552 us
Division: 1684860 us
So we'd need to investigate all the different ABIs and switch the type on platform. I'll note that my primary development is on ARM Mac. Another win for Intel's complete vertical integration.
Matt
