
2 Jun
2012
2 Jun
'12
5:34 a.m.
2012/6/1 Michel Morin <mimomorin@gmail.com>:
Akira Takahashi wrote:
Source Code: https://github.com/faithandbrave/OvenToBoost
Small nitpicking:
[adaptor/dropped_while.hpp] * Don't forget `#pragma warning(pop)`.
[as_container.hpp] * Missing include guard.
[detail/indirect_functor.hpp] * Use `BOOST_NO_XXXX` to detect C++11 features (`BOOST_HAS_XXXX` is deprecated). * Even if a compiler supports C++11, the availability of `std::forward` in the standard library is not guaranteed. Use `static_cast` as substitute of `std::forward`. (Or just abandon such a pathological case and use `std::forward`.)
Thanks for many review. Fixed!