Re: [boost] Constructing string_ref from rvalue string

I'll also point out that that commit was in response to this bug report: https://svn.boost.org/trac/boost/ticket/11740

I see. Using boost::string_ref in that way (local variable) would raise a big red flag for us. So i understand that the change does add some safety, but it also breaks usages that are completely fine. We 'solved' the safety issue with a really simple rule (only use boost::string_ref as function parameters).