----- Original Message -----
From: Joshua Boyce <raptorfactor@raptorfactor.com> On Sun, Jun 3, 2012 at 1:16 AM, Artyom Beilis <artyomtnk@yahoo.com> wrote:
Looking forward for more comments on a library that I want to submit for a
Hi,
First off, I'd like to say that I'm excited to see this become a part of Boost.
As for feedback, I have one suggestion and one nitpick.
Suggestion: It would be nice if you could check the existing BOOST_USE_WINDOWS_H as well as BOOST_NOWIDE_USE_WINDOWS_H.
Good point, I was not aware of BOOST_USE_WINDOWS_H
Nitpick: cenv.hpp:48 The check on GetLastError is pointless. A return value of zero is indicative of failure, regardless of the specific reason,
It may return 0 if the environment string is an empty string.
so there's no point doing further processing (As it currently stands, in the case that GetEnvironmentVariable fails with a different error code you will still call value.convert.).
Also you are right, it is good idea to check if it returns some other error
Thanks . Good luck with your future review.
Thanks for inputs, Artyom