-----Original Message----- From: boost-bounces@lists.boost.org [mailto:boost-bounces@lists.boost.org] On Behalf Of Matthieu Schaller Sent: Tuesday, May 01, 2012 10:49 AM To: boost@lists.boost.org Subject: Re: [boost] [complex] Feedback and Potential Review Manager
1) Various functions use macros like M_PI_2. These macros do not provide enough precision for a multiprecision type. And they will be inefficient for some fixed-point types. Perhaps you need to "bite the bullet" and use boost::math::constants. (Is M_PI_2 even part of C++, or is it only lurking around in<math.h> of GCC?) 2) Ditto for the LN_10 and LN_2 constants. Does boost::math::constants support ln_ten()? I do know that it has ln_two(). You are right, M_PI_2 is not standard although present in gcc, icc and Visual C++. I will move the constants to boost::math::constant. LN_10 exists under the name one_div_log10_e as Paul Bristow mentioned.
now added ln_10 as a constant. Command: Commit Modified: I:\boost-trunk\boost\math\constants\calculate_constants.hpp Modified: I:\boost-trunk\boost\math\constants\constants.hpp Sending content: I:\boost-trunk\boost\math\constants\calculate_constants.hpp Sending content: I:\boost-trunk\boost\math\constants\constants.hpp Completed: At revision: 78288 You can get this from boost-trunk by SVN but please tell me if you would prefer constants.hpp direct by private mail. Tell me also if there are other constants that you need.
Paul Bristow: PS Might Matthieu be qualified as a review manager for Boost.Multiprecision? Boost badly needs this reviewed soon (and preferably accepted!) I am afraid I am not qualified for software assessment. Furthermore, I have never taken part to a boost review.
:-( But I hope you will participate in the review of Boost.Math nonetheless. Paul --- Paul A. Bristow, Prizet Farmhouse, Kendal LA8 8AB UK +44 1539 561830 07714330204 pbristow@hetp.u-net.com