Sohail Somani wrote:
Any opinions on this? It is a patch against 1.33.1. It is meant to be non-intrusive: nothing should change unless you want it to. The idea is that when building boost threads, you require language extensions via your silence on BOOST_NO_REQUIRE_LANGUAGE_EXTENSIONS but if you are not building boost threads, you don't need language extensions. The idea is that BOOST_DISABLE_WIN32 does not need to be defined if language extensions are not needed.
I would appreciate any feedback towards a possible patch. I am currently running the boost thread tests and hoping that they don't fail ;) If all goes well, I will rebuild the rest of boost as well and run tests there.
Unfortunately that's going to break all kinds of things: Regex and Boost.Test almost for sure. I suggest you do a grep for BOOST_DISABLE_WIN32 and BOOST_HAS_THREADS: you will find their use ubiquitous throughout Boost. John.