Re: [boost] Warning policy? local variable hides (i.e. shadows) global variable

On Thu, Jan 15, 2015 at 10:09 AM, Olaf van der Spek wrote:

On Thu, Jan 15, 2015 at 2:11 PM, Beman Dawes wrote:

...

A lot of the warnings involve function argument names. Should we have a guideline to prevent shadow warnings? A convention for argument names would make it easier to submit pull requests. Possible guidelines:

* Prefix function argument names with "a_". Rationale: The "m_" prefix for member names has been a success. * Suffix function argument names with "_". Rationale: Short and less distracting than "m_" prefix.

Thoughts?

The "_" suffix is used for member names too.

Hummm... You are right. So like with the "m_" prefix, a boost library wishing to avoid shadowing would need to use deliberately ugly or unusual formal parameter names. Ugh! --Beman