
John Maddock wrote:
Johan Råde wrote:
John,
Do you have time to test the fpclassify library again?
[snip] it passes on all the platforms I can think of (and test on).
Great!! Thanks for your help.
I did have to add "uLL" to the end of the 64-bit constants though to get it to compile with gcc-3.4.4 on Linux/Xeon.
This is a tricky one because you need uLL if uint64_t is a long long and ui64 if it's a MSVC++ specific unsigned __int64.
I have fixed that. Now I write ((uint64_t)0x000fffff << 32) + (uint64_t)0xffffffff instead of 0x000fffffffffffff Not pretty, but it should work on all platforms that suppport uint64_t. ------------------------------ So what is left to do now? 1. Boostify the tests. (The library itself is already boostified, I think.) 2. Better documentation. 3. Formal review. Anything else? --Johan