19 May
2008
19 May
'08
4:38 p.m.
Hi again.
I renamed the local CRITICAL_SECTION to critical_section to avoid this ambiguity. See revision 45545.
Could you also add the comment from the original patch to explain why this has been done? Since there are no tests prepared that would catch this if it ever regressed...
Also... the renamed class name as used in the original patch seemed clearer since Visual C++ still has a bug with exposing this identified in the global namespace... and 'critical_section' seems much more likely to cause problems than critical_section__whatever_we_write_here_as_an_explanation. Best regards, Jurko Gospodnetić