On Mon, Oct 9, 2017 at 12:48 PM, Peter Dimov via Boost < boost@lists.boost.org> wrote:
Steven Watanabe wrote:
On 10/09/2017 05:22 AM, Peter Dimov via Boost wrote:
Regardless of one's personal preference regarding Github issues, I
think > that we all ought to agree that Github pull requests are infinitely
better than Trac patches (were much better even without CI, now it's not even a contest).
To be honest, I prefer patches, because it means I have to deal with git less.
A Github PR can be merged without touching git at all. :-)
Apart from that, it's a toss-up; you have to git checkout develop; git pull, then apply the patch (which is a single git pull in the PR case, download the patch and 'patch' in the patch case) then test and git commit + git push. The PR wins for me as there's no separate download step.
If you set up CI jobs properly, anyone can submit a PR and it will be tested to your satisfaction automatically (to the extent that travis and appveyor support the platforms you want tested), then all you have to do is click merge. I'm not sure how you would take a patch, apply, and test it in fewer steps than that, and it doesn't require you to use git. - Jim