Hi Bjorn, On 2015-05-31 12:41, Bjorn Reese wrote:
The code base does not follow the Boost directory structure, nor does it appear to use Boost.Build. When the project was created, it did follow the directory structure Boost had at the time (but was using the mpllibs namespace instead of boost to make it clear that it is not part of Boost). It is part of a repository that follows the old directory structure (there are a few other libs in the same project as well). I did not make the same structural change in Mpllibs that Boost did, however, if Metaparse gets accepted I'll move it to its own repository and change the namespace, etc (apply other changes that are needed for the integration).
The code is not located within a boost namespace. It is located in mpllibs::metaparse. It was intentionally designed in a way that in case it gets accepted, it can be (easily for the developers and users of the library) moved to the boost::metaparse namespace.
The documentation does not appear to be in QuickBook. The documentation is in MarkDown format, from which static HTML files can be automatically generated, which is (to the best of my knowledge) the requirement for the format of the documentation.
More importantly, it is unclear to me exactly how much is part of the review. For instance, are the examples [1] part of the submission? You only point to the "Getting Started" documentation, but what about the rest of the documentation? Are both v1 and v2 part of the submission (and if so, why does it contain v1?) The structure of the mpllibs repository follows the old structure of the Boost repository and from that the metaparse library is part of the review (the content of the mpllibs/metaparse and libs/metaparse directories recursively). Yes, the examples and the entire Metaparse documentation (the markdown source of the documentation is in the libs/metaparse/doc directory, the generated HTML files can be viewed at http://abel.web.elte.hu/mpllibs/metaparse) are part of the review.
Good question about v1 and v2. The library is currently part of Mpllibs, where I have already released 1.0.0 and I've made breaking API changes to Metaparse since then. That is why I have the v2 namespace. If the library gets accepted to Boost, it is safe to start the versioning over (as there is a namespace change anyway) and drop the "old" v1, so in that sense only v2 is part of the review. Regards, Ábel