Re: [boost] Boost.Log: Any Comments? (Was: [log] Permission to merge to trunk)

-----Original Message----- From: Boost [mailto:boost-bounces@lists.boost.org] On Behalf Of Andrey Semashev Sent: Monday, April 01, 2013 3:56 PM To: boost@lists.boost.org Subject: Re: [boost] Boost.Log: Any Comments? (Was: [log] Permission to merge to trunk)

On Mon, Apr 1, 2013 at 6:24 PM, wrote:

...

There is one thing that might impact the 'warnings as errors' crowd.

There are phoenix warnings generated as a side-effect of using log.

Who owns these issues, the library or the consumer?

I think, maintainers of each library are free to choose their own policy with regard to warnings. You can contact Boost.Phoenix authors for their opinion on this, or create a Trac ticket (preferably, with a patch).

Personally, I feel reluctant to maintain hard no-warnings guarantee in Boost.Log, simply because it's too tedious and most warnings on higher levels are bogus anyway and trying to avoid them only makes

the

code worse. I try to keep the code silent on normal levels, however.

Can you *suppress warnings* - some suggestions are at https://svn.boost.org/trac/boost/wiki/Guidelines/WarningsGuidelines Using push'n'pop around troublesome sections usually works, and isn't too tedious to implement. Of course warnings deep in Phoenix may be more difficult to avoid, but you still should be able to. Since there are shops that require use of higher warnings levels, or even warnings as errors, (despite what you might think about their decisions) you may make your reportedly excellent and very widely applicable log library unusable for them. This would be a pity? Paul --- Paul A. Bristow, Prizet Farmhouse, Kendal LA8 8AB UK +44 1539 561830 07714330204 pbristow@hetp.u-net.com https://svn.boost.org/trac/boost/wiki/Guidelines/WarningsGuidelines