Anthony Williams wrote:
"Peter Dimov" <pdimov@mmltd.net> writes:
Anthony Williams wrote:
"Peter Dimov" <pdimov@mmltd.net> writes:
Anthony Williams wrote:
Can we have a call to TlsFree in on_process_exit, so we don't leak the TLS slot either?
If on_process_exit is guaranteed to be called after all on_thread_exits (if it's called at all), it will indeed be safe (but still redundant) to TlsFree the slot in it.
I believe this to be the case.
So it seems. I was thinking that we could choose the other direction and simplify the tss_hooks interface by removing on_process_* and on_thread_enter (I have a call_once in it but it's actually redundant.) But I don't really have a strong opinion one way or the other. So let's do it this way: I'll commit my replacement as-is and you'll add the TlsFree in on_process_exit if you wish. :-)