On Fri, Feb 08, 2008 at 04:31:39PM +0000, Phil Endecott wrote:
John Torjo wrote:
Someone else told me privately about these - I fixed them but did not commit. However, I've committed the changes now - please take the latest version from SVN.
Done, thanks. Here's the next batch: unsigned vs. signed comparisons:
John, please try to test your code before you commit. There are even some errors in namespaces which cause trouble during compilation. I attached a trivial patch. I tested beside header files using my check_boost script also all *.cpp files using for i in $(find -name "*.cpp"); do /usr/lib/gcc-snapshot/bin/g++ -Wall -O3 -Wno-long-long -W -pedantic -I /home/jens/Programme/Entwicklung/Boost/svn/logging/ -I /home/jens/Programme/Entwicklung/Boost/svn/trunk/ $i -c -o /tmp/test.o; done | tee /tmp/log and got the attached output. You can probably indeed not fix all warnings such as warning: type qualifiers ignored on function return type which results from code like: template<class T> T function(T) { return T() } with T = const char. Changing the return value from const char to char would fix this problem. Also look at /usr/lib/gcc-snapshot/lib/gcc/i486-linux-gnu/4.3.0/../../../../include/c++/4.3.0/bits/stl_algo.h: In function 'char* boost::debug::<unnamed>::prepare_window_title(const boost::debug::dbg_startup_info&)': /usr/lib/gcc-snapshot/lib/gcc/i486-linux-gnu/4.3.0/../../../../include/c++/4.3.0/bits/stl_algo.h:202: warning: array subscript is above array bounds It's somewhere in Boost.Test but since snprintf is properly used I don't understand the warning. PS: Please wrap your lines. Parts of the patch will be unreadable for you because some lines are just too long. Jens