"David Abrahams" <dave@boost-consulting.com> wrote in message news:uwtsv1i84.fsf_-_@boost-consulting.com...
"Gennadiy Rozental" <gennadiy.rozental@thomson.com> writes:
"Gennadiy Rozental" <gennadiy.rozental@thomson.com> wrote in message news:cvpn38$2fi$1@sea.gmane.org...
1. Shouldn't this header use workaround from config/suffix.hpp instead of BOOST_EXPLICIT_DEFAULT_TARGET?
Sure.
2. Shouldn't this header be split by ..._cast?
Sure.
Does above 'sure' means you are going to take care about it, or you want me to do it?
3. Doesn't numeric_cast facility shouldn't be deprecated? ^^^^^^^ ^^^^^^^^^ ?? Double negative??
Its implementation should be replaced by one that uses the Boost Numeric Conversion Library.
I think just include boost/numeric/cast.hpp will work. And test program should be depricated either. BTW I noticed that this test (either original in libs/convertion/test or copy in libs/numeric/convertion/test) could use use BOOST_TEST_THROW in stead of handcrafted checks.
4. Shouldn't polymorphic_downcast work for references?
I have no opinion.
In a book you have this in excesises. And i do not see why not?
-- Dave Abrahams
Gennadiy