Vicente J. Botet Escriba wrote:
Le 13/01/15 22:05, Peter Dimov a écrit :
I suppose I should probably fix Rational, because it currently has no maintainer.
It has many unmerged changes though, some quite extensive.
I'm also getting a test failure on develop (with msvc-8.0):
rational_test.cpp(983): error: in "rational_cross_constructor_test": check half_mu2.denominator() == MyOverflowingUnsigned(2u) has failed [1635872 != 2]
that is not present on master.
Are these changes fixing some bugs?
Yes, it seems so. The failure above is actually in a new test, so it's not a regression. It's also only present on msvc-8.0, and even there, if I extract the test code into a separate program, the denominator has the expected value of 2. It could be some odd interaction with Test, but I've no time to investigate. The develop changes seem beneficial, so I'll just merge them.