
21 Jan
2025
21 Jan
'25
5:48 p.m.
Some random observations: https://github.com/cppalliance/decimal/blob/069c26a111b33123e6ce5c34b4bb0077... The class doesn't need to be marked as EXPORT, because all its members are constexpr (or templated), and hence, nothing is actually exported. https://github.com/cppalliance/decimal/blob/069c26a111b33123e6ce5c34b4bb0077... The special inf value is higher than the special NaN values, which causes isnan() to perform a biased compare https://godbolt.org/z/78P73r986 instead of a straight one https://godbolt.org/z/ebr3EsxWf (I've changed the exponent type here to uint16_t to avoid the pessimization identified earlier.)