Hi Rene, Thank you for merging the PR. How will it move to the master branch? Will the develop branch be propagated at some point or should I create another pull request for the master branch? Regards, Abel On 2015-10-20 07:51, Abel Sinkovics wrote:
Hi Rene,
I've fixed the image copying issue (inside Metaparse and I've updated the pull request to point the submodule to the latest commit).
I'm not aware of any further issues with Metaparse and its integration.
Regards, Abel
On 2015-10-20 00:47, Abel Sinkovics wrote:
Hi Rene,
I've created a pull request to the develop branch. The CI scripts of Metaparse have been testing the library in the Boost source tree, so I expect the tests and examples to build fine.
I've migrated the documentation to Quickbook, so I added it to the list of BoostBook-based libraries. I can generate the documentation in the doc directory of the library, however, when I try to generate all BoostBook documentations from the "main" doc directory of the Boost source tree, the png images don't get copied to the right place. So currently they need to be copied to html/images/metaparse manually after the documentation generation in that case.
Regards, Abel
On 2015-10-18 23:02, Rene Rivera wrote:
On Sun, Oct 18, 2015 at 4:01 PM, Rene Rivera
wrote: On Sun, Oct 18, 2015 at 3:37 PM, Abel Sinkovics
wrote: Hi Rene,
Yes, I'm done and it looks like the CI environments work as well. Thank you for your help.
For the rest of the migration: am I supposed to create a pull request for the boostorg/boost repository adding the new submodule, the new entries to maintainers.txt, libraries.htm, etc? Or is it maintained by scripts? (Is there maybe a description of this somewhere?)
For most of those, yes, create a PR. But also make sure to have the meta info in your repo also as some of the files are updated from that info. Although I don't remember which ones are :-\
Forgot to mention.. Remember that all PRs should be for develop branch first.