Patches item #1489352, was opened at 05/16/06 00:20 Message generated for change (Comment added) made by sf-robot You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=307586&aid=1489352&group_id=7586 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None
Status: Closed Resolution: Accepted Priority: 5 Submitted By: Michael Fink (vividos) Assigned to: Peter Dimov (pdimov) Summary: evc4 port: Interlocked*-functions without volatile
Initial Comment: This patch fixes the definition of the Interlocked*-functions when using Windows CE (_WIN32_WCE is defined). The functions use the "old" (VC6 without platform SDK) forms of the functions without the volatile keyword. The patch can be applied to both CVS HEAD and the 1_34 branch, since the file wasn't modified since then. ----------------------------------------------------------------------
Comment By: SourceForge Robot (sf-robot) Date: 06/13/06 19:20
Message: Logged In: YES user_id=1312539 This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker). ---------------------------------------------------------------------- Comment By: Peter Dimov (pdimov) Date: 05/17/06 15:41 Message: Logged In: YES user_id=305912 Applied to 1.34 and HEAD. ---------------------------------------------------------------------- Comment By: Michael Fink (vividos) Date: 05/17/06 00:57 Message: Logged In: YES user_id=124874 I added a new version of the patch that avoids WINAPI (replaced by __cdecl, as used by the BOOST_MSVC part of the file. Including <windows.h> is not needed here, I think. In evc4 there are no intrinsics for the Interlocked-functions and the pragmas produce errors telling so. The _WIN32_WCE part of the file provides the BOOST_INTERLOCKED_ macros in its own section now. ---------------------------------------------------------------------- Comment By: Peter Dimov (pdimov) Date: 05/16/06 03:42 Message: Logged In: YES user_id=305912 The patch doesn't look correct to me. Using WINAPI would require inclusion of <windows.h>; in this case just defining BOOST_USE_WINDOWS_H would be a better approach. It also patches the intrinsic section without also declaring the functions as intrinsics; is this intended? Does evc4 have intrinsic support for these functions? If it doesn't, we need to disallow the intrinsic path for _WIN32_WCE and patch the WIN32 section instead. ---------------------------------------------------------------------- Comment By: Michael Fink (vividos) Date: 05/16/06 00:40 Message: Logged In: YES user_id=124874 Changed summary: it's only evc4 of course, since evc3 is too non-standard to support boost. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=307586&aid=1489352&group_id=7586 _______________________________________________ Boost-bugs mailing list Boost-bugs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/boost-bugs