on Tue Jul 29 2008, "Niels Dekker - mail address until 2008-12-31" <nd_mail_address_valid_until_2008-12-31-AT-xs4all.nl> wrote:
Last Friday I added "test_adl_barrier" to test this ADL barrier. Unfortunately it fails on many compilers, including XL (AIX), Intel (version 9 and 10), GCC, Sun and Como: http://www.boost.org/development/tests/trunk/developer/utility-swap_.html
David Abrahams wrote:
Try replacing the using declaration with a using directive in swap.hpp Appears to work for GCC.
Thanks, Dave. Unfortunately for MSVC, most of the tests would be broken, when doing so! So I guess we would need to do an #if BOOST_WORKAROUND within swap.hpp, e.g., as follows:
#if BOOST_WORKAROUND( BOOST_MSVC, BOOST_TESTED_AT(1500) ) using swap_adl_barrier::swap; #else using namespace swap_adl_barrier; #endif
Right? I only tested it on MSVC, because I don't have direct access to an up-to-date GCC compiler at the moment. Shall I just commit it and see how the regression goes?
To the trunk, yeah, that seems right. I didn't have time to dig up the standard language on this. Steven, are you sure it was supposed to work with the using-declaration? Failing como tests make me suspicious. -- Dave Abrahams BoostPro Computing http://www.boostpro.com