Graham Bennett <graham-boost@simulcra.org> writes:
Hi,
Attached is a patch to fix some compilation errors with sunpro CC 5.3. It seems to apply correctly to the current CVS.
cheers,
Graham.
-- Graham Bennett
diff -c -r boost_1_33_0-orig/boost/config/compiler/sunpro_cc.hpp boost_1_33_0/boost/config/compiler/sunpro_cc.hpp *** boost_1_33_0-orig/boost/config/compiler/sunpro_cc.hpp Tue Mar 22 10:55:03 2005 --- boost_1_33_0/boost/config/compiler/sunpro_cc.hpp Mon Sep 5 16:09:32 2005 *************** *** 55,60 **** --- 55,63 ----
// integral constant expressions with 64 bit numbers fail # define BOOST_NO_INTEGRAL_INT64_T + + // fix for iterator
I think you should remove that comment. Either the compiler is broken in this respect or it isn't; it has nothing to do with the iterator library.
+ # define BOOST_NO_MEMBER_TEMPLATE_FRIENDS # endif
# if (__SUNPRO_CC < 0x570) diff -c -r boost_1_33_0-orig/boost/iterator/iterator_facade.hpp boost_1_33_0/boost/iterator/iterator_facade.hpp *** boost_1_33_0-orig/boost/iterator/iterator_facade.hpp Sat Mar 12 23:10:43 2005 --- boost_1_33_0/boost/iterator/iterator_facade.hpp Mon Sep 5 16:11:53 2005 *************** *** 809,815 **** # ifdef BOOST_NO_ONE_WAY_ITERATOR_INTEROP # define BOOST_ITERATOR_CONVERTIBLE(a,b) mpl::true_() # else ! # define BOOST_ITERATOR_CONVERTIBLE(a,b) is_convertible<a,b>() # endif
# define BOOST_ITERATOR_FACADE_INTEROP(op, result_type, return_prefix, base_op) \ --- 809,815 ---- # ifdef BOOST_NO_ONE_WAY_ITERATOR_INTEROP # define BOOST_ITERATOR_CONVERTIBLE(a,b) mpl::true_() # else
I think you need a comment here explaining that ::type() is needed for Sun CC, or a maintainer might be tempted to remove it.
! # define BOOST_ITERATOR_CONVERTIBLE(a,b) is_convertible<a,b>::type() # endif
# define BOOST_ITERATOR_FACADE_INTEROP(op, result_type, return_prefix, base_op) \ _______________________________________________ Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Other than that, please feel free to check it in! -- Dave Abrahams Boost Consulting www.boost-consulting.com