Re: [boost] Formal review request for Hash2

Thank you for the answers. On Tue, Dec 3, 2024 at 1:54 AM Peter Dimov wrote:

Either way, N3980 is what I liked best, so that's what I based the library on.

Regarding design:

I noticed all hash_append* functions take flavor so users often have to write {} argument . Do you think there would be some benefit for easy use helper, e.g. to have something like this from example boost::hash2::fnv1a_32 h1; int v1[4] = { 1, 2, 3, 4 }; boost::hash2::hash_append( h1, {}, v1 ); writable also as boost::hash2::simple_hash h1; int v1[4] = { 1, 2, 3, 4 }; h1.append( h1, v1 ); // shorter fn name, no {}, simple_hash flavor is always default flavor