Beman Dawes wrote:
On Fri, Jul 8, 2011 at 1:26 AM, Vicente Botet <vicente.botet@wanadoo.fr> wrote:
I have committed https://svn.boost.org/trac/boost/changeset/72938 on trunk a simple patch. Can I commit after verification on trunk?
Adding an extra set of superfluous parens makes the compiler happy? Really? That's whack.
Looks totally safe to me, but I don't know if Beman is in the packaging phase of the release yet. Beman?
I'm build release candidates now. So unless there is a further delay, it is just too late for this release.
If the release is not closed yet, could I or you merge this safe update?
The release is closed except by permission. Yes, please do merge changeset 72938.
Just out of curiosity, why does the Intel compiler want the extra set of parentheses?
I have no idea why. Edward has requested to people from Intel but I don't have yet a response. I have tried to commit it, but I have no permission. svn ci duration.hpp -m "Merge Intel issue with default bool template initialization #72938" Sending duration.hpp Transmitting file data .svn: Commit failed (details follow): svn: Commit blocked by pre-commit hook (exit code 1) with output: U branches/release/boost/chrono/duration.hpp svn diff duration.hppIndex: duration.hpp =================================================================== --- duration.hpp (revision 72948) +++ duration.hpp (working copy) @@ -89,10 +89,10 @@ template <class Duration, class Rep2, bool = ( - (boost::is_convertible<typename Duration::rep, - typename common_type<typename Duration::rep, Rep2>::type>::value) - && (boost::is_convertible<Rep2, - typename common_type<typename Duration::rep, Rep2>::type>::value) + ((boost::is_convertible<typename Duration::rep, + typename common_type<typename Duration::rep, Rep2>::type>::value)) + && ((boost::is_convertible<Rep2, + typename common_type<typename Duration::rep, Rep2>::type>::value)) ) > struct duration_divide_imp @@ -119,10 +119,10 @@ template <class Rep, class Duration, bool = ( - (boost::is_convertible<typename Duration::rep, - typename common_type<typename Duration::rep, Rep>::type>::value) - && (boost::is_convertible<Rep, - typename common_type<typename Duration::rep, Rep>::type>::value) + ((boost::is_convertible<typename Duration::rep, + typename common_type<typename Duration::rep, Rep>::type>::value)) + && ((boost::is_convertible<Rep, + typename common_type<typename Duration::rep, Rep>::type>::value)) ) > struct duration_divide_imp2 Is this because I have not used the merge command? Best, Vicente -- View this message in context: http://boost.2283326.n4.nabble.com/1-47-0-Any-remaining-showstoppers-tp36456... Sent from the Boost - Dev mailing list archive at Nabble.com.