On 19 May 2011 18:32, Antony Polukhin <antoshkka@gmail.com> wrote:
2011/5/19 Jeroen Habraken <vexocide@gmail.com>:
Hi,
Whilst updating SVN today I spotted a change to boost::lexical_cast, https://svn.boost.org/trac/boost/changeset/71958, which introduces a try { } catch(...) { } construction. I'm curious as to why this catch-all is needed since it seems to be there to deal with boost::numeric_cast exceptions and whether it could lead to a std::bad_alloc being rethrown as a bad_lexical_cast.
numeric_cast does not use new operator, so std::bad_alloc will not be rethrown as a bad_lexical_cast. But you are right, and it will be more appropriate to catch only boost::numeric_cast exceptions. I`ll fix it in next commit. Great thanks for reporting this.
Thanks!
Best regards, Antony Polukhin
Jeroen