
26 Feb
2008
26 Feb
'08
4:54 p.m.
Phil Endecott wrote:
OK, the code is here: http://svn.chezphil.org/libpbe/trunk/include/charset/
Playing around with implementing a very simple immutable string with shared representation based on the concepts, and I found that your current charset traits cannot deal with shift encodings. Basically, you miss the shift state in all relevant functions: skip_forward/backward_char, encode, decode and char_length. Also, const_unit_ptr_t is not a very good template parameter name. It's misleading, since the user might assume the type has to be a pointer, where an iterator suffices. Sebastian