On Mon, 20 Mar 2006 02:02:41 -0800, Stephan T. Lavavej wrote
Hi,
Boost 1.33.1 contains a number of constructs which cause warnings when compiled with GCC 3.4.2 (and other versions) using some warning flags. The majority of warnings are -Wshadow warnings and are easily correctable. One is a C cast that should be written as a const_cast. The most severe one is an omission of "const" that produces a warning under -Wcast-qual.
Thx for the reminder before the branch for release...
I maintain a local patch that fixes these things (as otherwise I can't use these warning flags on my own code), but it'd be really nice if they were fixed in Boost mainline. The C cast and -Wcast- qual problems have obvious fixes. My fixes for the -Wshadow warnings involve prepending x_ to variable names, since I don't need to be inventive. Better names should probably be chosen.
Yep.
I reported these problems against 1.33.0, but they appeared unchanged in 1.33.1.
My patch is here: http://stl.nuwen.net/boost-1.33.1.patch
* The following files have shadow warnings: boost/date_time/gregorian/gregorian_io.hpp boost/date_time/period_formatter.hpp boost/date_time/time_duration.hpp boost/date_time/time_system_counted.hpp
I've applied a modified form of your patches to CVS for the date_time files. Thx again. Jeff