-----Original Message----- From: boost-bounces@lists.boost.org [mailto:boost-bounces@lists.boost.org] On Behalf Of Anthony Williams Sent: Monday, September 27, 2010 11:01 PM To: boost@lists.boost.org Cc: boost-announce@lists.boost.org Subject: [boost] [Review] Formal Review: Boost.Ratio
The review of Vicente Botet' Ratio library starts October 2nd and lasts until October 11th, 2010, unless an extension occurs. It is worth noting that the tests included in the zip file are relatively sparse. Vicente has an extensive suite of tests licensed under the LLVM license. He has posted a message on the Boost Developers mailing list regarding the license requirements for tests (See http://thread.gmane.org/gmane.comp.lib.boost.devel/208978), and is awaiting the outcome of that discussion before making the tests available.
If we decide we can't include the LLVM licensed tests, I think a small subset of tests will suffice - since we have the knowledge that it has been tested using non-Boost licensable test code. Anyone who really cares about more tests can get them and use them if their legal advisers permit. (I find the idea that seeing the LLVM code would make a work 'derivative' more than a bit far-fetched).
Here are some questions you might want to answer in your review: - What is your evaluation of the design? FWIW, I see no snags.
- What is your evaluation of the implementation? Seem mature.
- What is your evaluation of the documentation? OK, but needs proof reading by a non-author. Too many typos!
- What is your evaluation of the potential usefulness of the library? A 'must have' building block, and asap.
- Did you try to use the library? With what compiler? Did you have any problems? No.
- How much effort did you put into your evaluation? A quick re-reading
- Are you knowledgeable about the problem domain? Not much.
- Do you think the library should be accepted as a Boost library? Yes.
Paul --- Paul A. Bristow, Prizet Farmhouse, Kendal LA8 8AB UK +44 1539 561830 07714330204 pbristow@hetp.u-net.com