On 5/21/2014 12:25 AM, Vladimir Batov wrote:
On 05/21/2014 01:17 PM, Edward Diener wrote:
On 5/20/2014 10:50 PM, Vladimir Batov wrote:
On 05/21/2014 12:41 PM, Edward Diener wrote:
On 5/20/2014 9:29 PM, Vladimir Batov wrote:
On 05/20/2014 07:15 PM, Rob Stewart wrote:
I don't mind the clear separation of the input and output types, but if "from" can be avoided easily, do so.
Encouraged ;-) I could not resist the itch and got rid of "::from". Updated the code and the docs.
Please do not update the code or the docs while the review is ongoing. By doing so you make it impossible for everyone reviewing your source to be reviewing the same thing. You can of course make updates but not to the master branch.
Sorry, Edward. You are right. I am sorry. No more for the time being.
Please revert immediately all changes you have made to the master branch since the beginning of the review.
You can save your current changes to another branch but you must return the master branch to the way it was when the review started. The review started on May 12 so you must revert your changes back to just before that date.
It is possibly my fault but I thought that you knew that during a review no changes are allowed to the source being reviewed else people reviewing a library are seeing different source when they download the source for review.
Sorry, Edward, the fault is all mine. Now I remember you mentioning no-changes... just thought that late readers did not need to stumble over the issues mentioned by previous reviewers. I just branched/saved the latest changes to the "post_review" branch and I already have the "develop" branch which is in that "original" state. Now I am looking for how to reset "master" back to match "develop".
I think: git checkout master git reset --hard develop git push